You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Rich Feit (JIRA)" <be...@incubator.apache.org> on 2005/05/06 19:24:07 UTC

[jira] Created: (BEEHIVE-611) Bogus warnings when inheriting action methods that forward to other actions

Bogus warnings when inheriting action methods that forward to other actions
---------------------------------------------------------------------------

         Key: BEEHIVE-611
         URL: http://issues.apache.org/jira/browse/BEEHIVE-611
     Project: Beehive
        Type: Bug
  Components: NetUI  
    Versions: V1    
    Reporter: Rich Feit
 Assigned to: Rich Feit 
     Fix For: V1


To reproduce this, create the following two page flows:

parent/Controller.jpf:
----------------------
@Jpf.Controller
public abstract class Controller extends PageFlowController
{
    @Jpf.Action
    public abstract Forward abstractAction();

    @Jpf.Action(
        forwards={
            @Jpf.Forward(name="ab", path="abstractAction.do")
        }
    )
    public Forward forwardToAbstractAction()
    {
        return new Forward( "ab" );
    }
}

derived/Controller.jpf:
-----------------------
@Jpf.Controller(
    simpleActions={
        @Jpf.SimpleAction(name="begin", path="index.jsp")
    }
)
public class Controller extends parent.Controller
{
}


When you compile both of these page flows, you get this warning:

parent/Controller.java:21: warning: File "abstractAction.do" (reference inherited from a Jpf.Forward annotation on method forwardToAbstractAction in parent.Controller) could not be found in the web application.
    public Forward forwardToAbstractAction()


This is wrong on two counts:
    - The warning references parent/Controller.java when it should really be for derived/Controller.java.

    - The warning itself is invalid; abstractAction is a valid action.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (BEEHIVE-611) Bogus warnings when inheriting action methods that forward to other actions

Posted by "Alejandro Ramirez (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-611?page=all ]
     
Alejandro Ramirez closed BEEHIVE-611:
-------------------------------------


Verified fixed.  Executed the repro steps and we no longer get the warning.

NOTE: I had to modify the derived/Controller.jpf class because it needed an implementation of the inherited abstractAction() method.  Here is the actual Controller I used:
@Jpf.Controller(
    simpleActions={
        @Jpf.SimpleAction(name="begin", path="index.jsp")
    }
)
public class Controller extends j611.parent.Controller
{
    @Jpf.Action(
            forwards = {
                    @Jpf.Forward(name="test", path="index.jsp")
                    })
    public Forward abstractAction(){
        return new Forward("test");
    }
                    
}

> Bogus warnings when inheriting action methods that forward to other actions
> ---------------------------------------------------------------------------
>
>          Key: BEEHIVE-611
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-611
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: V1
>     Reporter: Rich Feit
>     Assignee: Alejandro Ramirez
>      Fix For: V1

>
> To reproduce this, create the following two page flows:
> parent/Controller.jpf:
> ----------------------
> @Jpf.Controller
> public abstract class Controller extends PageFlowController
> {
>     @Jpf.Action
>     public abstract Forward abstractAction();
>     @Jpf.Action(
>         forwards={
>             @Jpf.Forward(name="ab", path="abstractAction.do")
>         }
>     )
>     public Forward forwardToAbstractAction()
>     {
>         return new Forward( "ab" );
>     }
> }
> derived/Controller.jpf:
> -----------------------
> @Jpf.Controller(
>     simpleActions={
>         @Jpf.SimpleAction(name="begin", path="index.jsp")
>     }
> )
> public class Controller extends parent.Controller
> {
> }
> When you compile both of these page flows, you get this warning:
> parent/Controller.java:21: warning: File "abstractAction.do" (reference inherited from a Jpf.Forward annotation on method forwardToAbstractAction in parent.Controller) could not be found in the web application.
>     public Forward forwardToAbstractAction()
> This is wrong on two counts:
>     - The warning references parent/Controller.java when it should really be for derived/Controller.java.
>     - The warning itself is invalid; abstractAction is a valid action.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (BEEHIVE-611) Bogus warnings when inheriting action methods that forward to other actions

Posted by "Rich Feit (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-611?page=all ]
     
Rich Feit resolved BEEHIVE-611:
-------------------------------

     Assign To: Alejandro Ramirez  (was: Rich Feit)
    Resolution: Fixed

Fixed with revision 168643.

> Bogus warnings when inheriting action methods that forward to other actions
> ---------------------------------------------------------------------------
>
>          Key: BEEHIVE-611
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-611
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: V1
>     Reporter: Rich Feit
>     Assignee: Alejandro Ramirez
>      Fix For: V1

>
> To reproduce this, create the following two page flows:
> parent/Controller.jpf:
> ----------------------
> @Jpf.Controller
> public abstract class Controller extends PageFlowController
> {
>     @Jpf.Action
>     public abstract Forward abstractAction();
>     @Jpf.Action(
>         forwards={
>             @Jpf.Forward(name="ab", path="abstractAction.do")
>         }
>     )
>     public Forward forwardToAbstractAction()
>     {
>         return new Forward( "ab" );
>     }
> }
> derived/Controller.jpf:
> -----------------------
> @Jpf.Controller(
>     simpleActions={
>         @Jpf.SimpleAction(name="begin", path="index.jsp")
>     }
> )
> public class Controller extends parent.Controller
> {
> }
> When you compile both of these page flows, you get this warning:
> parent/Controller.java:21: warning: File "abstractAction.do" (reference inherited from a Jpf.Forward annotation on method forwardToAbstractAction in parent.Controller) could not be found in the web application.
>     public Forward forwardToAbstractAction()
> This is wrong on two counts:
>     - The warning references parent/Controller.java when it should really be for derived/Controller.java.
>     - The warning itself is invalid; abstractAction is a valid action.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira