You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/01/27 12:38:45 UTC

[GitHub] [libcloud] Kami opened a new pull request #1418: Fix S3 interoperability authentication in the Google Storage driver

Kami opened a new pull request #1418: Fix S3 interoperability authentication in the Google Storage driver
URL: https://github.com/apache/libcloud/pull/1418
 
 
   This pull request fixes a bug which would result in 401 invalid signature error when uploading an object with the Google Storage driver utilizing S3 Interoparability authentication when object mime / content type contained mixed casing (e.g. ``application/vnd.ms-excel.sheet.macroEnabled.12``).
   
   The issue is that we incorrectly lower cased the value of the ``Content-Type`` header. This pull request fixes that by making sure we leave that header value as is.
   
   Resolves #1417.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [libcloud] codecov-io edited a comment on issue #1418: Fix S3 interoperability authentication in the Google Storage driver

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1418: Fix S3 interoperability authentication in the Google Storage driver
URL: https://github.com/apache/libcloud/pull/1418#issuecomment-578730390
 
 
   # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1418?src=pr&el=h1) Report
   > Merging [#1418](https://codecov.io/gh/apache/libcloud/pull/1418?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/1b5d97db7a91fabe18356e81a1d1bb8da46e66ec?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/libcloud/pull/1418/graphs/tree.svg?width=650&token=PYoduksh69&height=150&src=pr)](https://codecov.io/gh/apache/libcloud/pull/1418?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##            trunk    #1418   +/-   ##
   =======================================
     Coverage   86.02%   86.02%           
   =======================================
     Files         368      368           
     Lines       77455    77455           
     Branches     7658     7658           
   =======================================
     Hits        66631    66631           
     Misses       7920     7920           
     Partials     2904     2904
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1418?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [libcloud/test/storage/test\_google\_storage.py](https://codecov.io/gh/apache/libcloud/pull/1418/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9zdG9yYWdlL3Rlc3RfZ29vZ2xlX3N0b3JhZ2UucHk=) | `97.04% <ø> (ø)` | :arrow_up: |
   | [libcloud/storage/drivers/google\_storage.py](https://codecov.io/gh/apache/libcloud/pull/1418/diff?src=pr&el=tree#diff-bGliY2xvdWQvc3RvcmFnZS9kcml2ZXJzL2dvb2dsZV9zdG9yYWdlLnB5) | `90.78% <100%> (ø)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1418?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1418?src=pr&el=footer). Last update [1b5d97d...c2fb6cd](https://codecov.io/gh/apache/libcloud/pull/1418?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [libcloud] codecov-io commented on issue #1418: Fix S3 interoperability authentication in the Google Storage driver

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1418: Fix S3 interoperability authentication in the Google Storage driver
URL: https://github.com/apache/libcloud/pull/1418#issuecomment-578730390
 
 
   # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1418?src=pr&el=h1) Report
   > Merging [#1418](https://codecov.io/gh/apache/libcloud/pull/1418?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/1b5d97db7a91fabe18356e81a1d1bb8da46e66ec?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/libcloud/pull/1418/graphs/tree.svg?width=650&token=PYoduksh69&height=150&src=pr)](https://codecov.io/gh/apache/libcloud/pull/1418?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##            trunk    #1418   +/-   ##
   =======================================
     Coverage   86.02%   86.02%           
   =======================================
     Files         368      368           
     Lines       77455    77455           
     Branches     7658     7658           
   =======================================
     Hits        66631    66631           
     Misses       7920     7920           
     Partials     2904     2904
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1418?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [libcloud/test/storage/test\_google\_storage.py](https://codecov.io/gh/apache/libcloud/pull/1418/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9zdG9yYWdlL3Rlc3RfZ29vZ2xlX3N0b3JhZ2UucHk=) | `97.04% <ø> (ø)` | :arrow_up: |
   | [libcloud/storage/drivers/google\_storage.py](https://codecov.io/gh/apache/libcloud/pull/1418/diff?src=pr&el=tree#diff-bGliY2xvdWQvc3RvcmFnZS9kcml2ZXJzL2dvb2dsZV9zdG9yYWdlLnB5) | `90.78% <100%> (ø)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1418?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1418?src=pr&el=footer). Last update [1b5d97d...c2fb6cd](https://codecov.io/gh/apache/libcloud/pull/1418?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [libcloud] Kami merged pull request #1418: Fix S3 interoperability authentication in the Google Storage driver

Posted by GitBox <gi...@apache.org>.
Kami merged pull request #1418: Fix S3 interoperability authentication in the Google Storage driver
URL: https://github.com/apache/libcloud/pull/1418
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services