You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2019/04/02 19:29:35 UTC

[kudu-CR] KUDU-2757: retry OpenSSL downloads 

Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12913


Change subject: KUDU-2757: retry OpenSSL downloads
......................................................................

KUDU-2757: retry OpenSSL downloads

Commit 3bdc32054 added retry for thirdparty downloads, however we should
do the same for downloaing the OpenSSL RPMs.

Change-Id: I0c5522b33efc674592b2c5c80a65b2b9c9af12f2
---
M thirdparty/install-openssl-el6-workaround.sh
1 file changed, 15 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/12913/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c5522b33efc674592b2c5c80a65b2b9c9af12f2
Gerrit-Change-Number: 12913
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>

[kudu-CR] KUDU-2757: retry OpenSSL downloads

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12913 )

Change subject: KUDU-2757: retry OpenSSL downloads
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12913/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12913/1//COMMIT_MSG@10
PS1, Line 10: downloadin
> downloading
Done


http://gerrit.cloudera.org:8080/#/c/12913/1/thirdparty/install-openssl-el6-workaround.sh
File thirdparty/install-openssl-el6-workaround.sh:

http://gerrit.cloudera.org:8080/#/c/12913/1/thirdparty/install-openssl-el6-workaround.sh@69
PS1, Line 69:   for attempt in 1 2 3; do
> This appears to be missing a 'done'. Can you test it on an el6.6 machine?
Ah, thanks for catching that. Tested it on an el6.6 machine.



-- 
To view, visit http://gerrit.cloudera.org:8080/12913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c5522b33efc674592b2c5c80a65b2b9c9af12f2
Gerrit-Change-Number: 12913
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Apr 2019 23:06:43 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2757: retry OpenSSL downloads

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12913 )

Change subject: KUDU-2757: retry OpenSSL downloads
......................................................................

KUDU-2757: retry OpenSSL downloads

Commit 3bdc32054 added retry for thirdparty downloads, however we should
do the same for downloading the OpenSSL RPMs.

Change-Id: I0c5522b33efc674592b2c5c80a65b2b9c9af12f2
Reviewed-on: http://gerrit.cloudera.org:8080/12913
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M thirdparty/install-openssl-el6-workaround.sh
1 file changed, 16 insertions(+), 6 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/12913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c5522b33efc674592b2c5c80a65b2b9c9af12f2
Gerrit-Change-Number: 12913
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-2757: retry OpenSSL downloads

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12913 )

Change subject: KUDU-2757: retry OpenSSL downloads
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12913/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12913/1//COMMIT_MSG@10
PS1, Line 10: downloaing
downloading


http://gerrit.cloudera.org:8080/#/c/12913/1/thirdparty/install-openssl-el6-workaround.sh
File thirdparty/install-openssl-el6-workaround.sh:

http://gerrit.cloudera.org:8080/#/c/12913/1/thirdparty/install-openssl-el6-workaround.sh@69
PS1, Line 69:   for attempt in 1 2 3; do
This appears to be missing a 'done'. Can you test it on an el6.6 machine?



-- 
To view, visit http://gerrit.cloudera.org:8080/12913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c5522b33efc674592b2c5c80a65b2b9c9af12f2
Gerrit-Change-Number: 12913
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Apr 2019 19:32:43 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2757: retry OpenSSL downloads

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12913 )

Change subject: KUDU-2757: retry OpenSSL downloads
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c5522b33efc674592b2c5c80a65b2b9c9af12f2
Gerrit-Change-Number: 12913
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 03 Apr 2019 00:00:41 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2757: retry OpenSSL downloads

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12913

to look at the new patch set (#2).

Change subject: KUDU-2757: retry OpenSSL downloads
......................................................................

KUDU-2757: retry OpenSSL downloads

Commit 3bdc32054 added retry for thirdparty downloads, however we should
do the same for downloading the OpenSSL RPMs.

Change-Id: I0c5522b33efc674592b2c5c80a65b2b9c9af12f2
---
M thirdparty/install-openssl-el6-workaround.sh
1 file changed, 16 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/12913/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0c5522b33efc674592b2c5c80a65b2b9c9af12f2
Gerrit-Change-Number: 12913
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)