[GitHub] [spark] khalidmammadov commented on pull request #35323: [SPARK-38025][SQL][TEST] Improve test suite ExternalCatalogSuite

[GitBox <gi...@apache.org>]

khalidmammadov commented on pull request #35323:
URL: https://github.com/apache/spark/pull/35323#issuecomment-1028423639


   > Thank you for making a PR, but I'd not care about the existing test cases. Technically, in the following your proposal, the previous column name `partCol1` sounds better than the newly proposed `a` because `partCol1` has a meaning `partition column` clearly.
   > 
   > ```scala
   > - val partition = CatalogTablePartition(Map("partCol1" -> "1", "partCol2" -> "2"), storageFormat)
   > + val partition = CatalogTablePartition(Map("a" -> "1", "b" -> "2"), storageFormat)
   > ```
   
   These were renamed as I have started using utility function that provides these partitions with these simple names. I can rename it in that function and throughout the suite if needed but I if you are saying these type of improvements are not necessary then I can close this and sister PR https://github.com/apache/spark/pull/35293. @dongjoon-hyun Please confirm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org