[GitHub] [inlong] chestnut-c commented on a diff in pull request #4869: [INLONG-4867][Manager] Add restrictions to the naming of some key fields

[GitBox <gi...@apache.org>]

chestnut-c commented on code in PR #4869:
URL: https://github.com/apache/inlong/pull/4869#discussion_r913360254


##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/cluster/ClusterRequest.java:
##########
@@ -44,18 +44,18 @@ public class ClusterRequest {
     @ApiModelProperty(value = "Primary key")
     private Integer id;
 
-    @NotBlank
+    @NotBlank(message = "cluster name cannot be blank")
     @ApiModelProperty(value = "Cluster name")
     private String name;
 
-    @NotBlank
+    @NotBlank(message = "cluster type cannot be blank")
     @ApiModelProperty(value = "Cluster type, including TUBE, PULSAR, DATA_PROXY, etc.")
     private String type;
 
     @ApiModelProperty(value = "Cluster url")
     private String url;
 
-    @NotBlank
+    @NotBlank(message = "clusterTags cannot be blank")
     @ApiModelProperty(value = "Cluster tags, separated by commas")
     private String clusterTags;

Review Comment:
   Why can't tag be empty？nothing to do with business



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org