You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by im...@apache.org on 2026/08/06 18:19:49 UTC
(asterixdb) 11/14: [NO ISSUE][MISC] += Document Gerrit remote and topic constraint
This is an automated email from the ASF dual-hosted git repository.
parshimers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git
commit bc11e55ca41f7b5e8efadf2197d96f770241ddcd
Author: Michael Blow <mi...@couchbase.com>
AuthorDate: Wed Aug 5 09:06:43 2026 -0400
[NO ISSUE][MISC] += Document Gerrit remote and topic constraint
Record what the `gerrit` remote points at
(ssh://<user>@asterix-gerrit.ics.uci.edu:29418/asterixdb) and how to
add it when missing, so the push command is actionable without prior
setup.
Also document the topic constraint: the tooling that applies a topic
across projects errors out when a project has more than one open
change carrying that topic, so work split into a stack of commits
within one repo must not put the shared topic on every commit. Record
the two ways out -- topic on the leaf commit only, or per-set
intermediate topics -- along with the rule that unrelated follow-up
work gets no topic.
Co-Authored-By: Claude Opus 5 <no...@anthropic.com>
Change-Id: Ibd49fdc6e7a09477179f994fb023e7ad5ade32ad
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21495
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Michael Blow <mb...@apache.org>
---
CLAUDE.md | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/CLAUDE.md b/CLAUDE.md
index ede9b86f82..8ac01ee892 100644
--- a/CLAUDE.md
+++ b/CLAUDE.md
@@ -26,6 +26,29 @@ The tree has two roots:
Files here carry the **Apache license header** (see `README.md`). Preserve it when editing or creating files.
+## Code Review
+
+Changes go through **Gerrit** (`asterix-gerrit.ics.uci.edu`), not GitHub pull requests. The `gerrit` remote points at `ssh://<user>@asterix-gerrit.ics.uci.edu:29418/asterixdb` (port `29418`, project `asterixdb`). If it is missing, add it with:
+
+```bash
+git remote add gerrit ssh://<user>@asterix-gerrit.ics.uci.edu:29418/asterixdb
+```
+
+Push a change (or a new patchset) for review:
+
+```bash
+git push gerrit HEAD:refs/for/<branch>
+```
+
+### Topics: at most one open change per project per topic
+
+A topic (`-o topic=<topic>`) groups the changes of one coordinated change spanning several repositories. **The tooling that applies a topic across projects fails when a project has more than one open change carrying the same topic.** So when the work in *this* repo is a stack of several commits, do not put the shared topic on every commit. Instead:
+
+- Put the topic only on the **leaf** (final) commit of the stack, and leave the preparatory commits topic-less; or
+- If the stack contains discrete sets of cross-project changes that can be submitted independently, give each set its **own intermediate topic**.
+
+Unrelated follow-up work (e.g. a docs tweak noticed along the way) should be pushed as its own change with **no topic**, or a different one — not added to the coordinated change's topic.
+
## AI Provenance Annotation
**When you (an AI agent) generate or assist with Java code in this tree, annotate it with `@AiProvenance`.** This records which model and tool produced the code so the contribution is auditable. The annotation is defined *here*, in this repository.