[GitHub] nir-sopher opened a new pull request #1859: cr-config: calculating the hash-id if needed

[GitBox <gi...@apache.org>]

nir-sopher opened a new pull request #1859: cr-config: calculating the hash-id if needed
URL: https://github.com/apache/incubator-trafficcontrol/pull/1859
 
 
   Hi,
   When adding a server via the old traffic ops, the xmpp_id field is saved to be the host_name.
   This field is used later on as an hashId, as part of cr-config,
   
   However, when using the API (and therefore portal v2) this field is not created, causing the hashId to be empty and interfere with content affinity.
   
   The suggested change comes to fix the issues for existing caches:
   - Caches added by the old UI: no change in hashId
   - Caches  added by the portal: hashId is calculated in the same way as by the old OPs, but now during the cr-config creation
   
   I believe that as this is a "calculated" field and not provided by the user, the approach of calculating it each time is better then fixing it in the DB, as it allows future changes in the algorithem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services