[jira] [Commented] (OOZIE-1793) Improve find bugs reporting for Oozie

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084147#comment-14084147 ] 

Hadoop QA commented on OOZIE-1793:
----------------------------------

Testing JIRA OOZIE-1793

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.    Tests run: 1505
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1457/

> Improve find bugs reporting for Oozie
> -------------------------------------
>
>                 Key: OOZIE-1793
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1793
>             Project: Oozie
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: trunk
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: OOZIE-1793.patch
>
>
> I couldn't figure out how to run findbugs against Oozie.  And even if it does work, it looks like it's just going to create an XML file.  
> Based on some minor refactoring to this [tutorial|http://www.petrikainulainen.net/programming/maven/findbugs-maven-plugin-tutorial/] and this [stack overflow message|http://stackoverflow.com/questions/7035112/any-easy-way-to-generate-a-findbug-html-report-from-maven-without-sitesite/10365954#10365954], I was able to improve our findbugs reporting.  Now, when you run {{mvn verify}} (which we use to generate a checkstyle report), it will also run findbugs and transform the resulting XML files into html files that are human readable.
> The hard part here will be actually going through the reports and fixing these bugs; but that's for other JIRAs :)



--
This message was sent by Atlassian JIRA
(v6.2#6252)