You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Ryan Christanson (JIRA)" <co...@jakarta.apache.org> on 2004/12/09 18:03:11 UTC

[jira] Created: (JELLY-175) patch for jelly-tags-interaction

patch for jelly-tags-interaction
--------------------------------

         Key: JELLY-175
         URL: http://nagoya.apache.org/jira/browse/JELLY-175
     Project: jelly
        Type: Improvement
 Environment: I've tested this in windows with and without cygwin.
    Reporter: Ryan Christanson
    Priority: Minor
 Attachments: patch.txt

I've attached a patch to the commons-jelly-tags-interaction jar. This
patch makes it so the interaction task will try to use jline:
http://jline.sourceforge.net/

Jline makes it so a java console will have tab completion, and
history, and other goodies.

This is great, because the maven-console plugin uses the
commons-jelly-tags-interaction jar. So if you update the
commons-jelly-tags-interaction jar, and then tell the maven console
plugin to use the new jar, then your maven console will have history,
and tab completion.

I've set it up to remember all of the commands typed in any console,
further it uses that history as the tab completion source - so you can
tab complete past commands.

I've tested this in windows and it works great, but in windows with
cygwin, it doesn't do the fancy completion, but still works.

By the way, in windows, jline's lib doesn't support arrows for
history, so use CONTROL+P and CONTROL+N.

Its possible that there might be a better way to integrate jline into
this lib, i've just done what looked like the quickest way to get it
working so my maven console would have history and tab completion.
Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (JELLY-175) patch for jelly-tags-interaction

Posted by "Ryan Christianson (JIRA)" <co...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/JELLY-175?page=comments#action_58233 ]
     
Ryan Christianson commented on JELLY-175:
-----------------------------------------

I've attached a new patch. Looks like the project.xml was the problem, in 1.11 the version of that file the deps section was deleted- so patch couldnt add the jline dep to it.

Wierd question- I don't rememeber what I did build this to use in maven (its been about 5 months!) It builds the jar, but I don't recall how I tested this before- I looked in my maven lib dir, but I dont see a jar to replace- does this get rolled into another jar?

me == lame.

Ryan

> patch for jelly-tags-interaction
> --------------------------------
>
>          Key: JELLY-175
>          URL: http://issues.apache.org/jira/browse/JELLY-175
>      Project: jelly
>         Type: Improvement
>  Environment: I've tested this in windows with and without cygwin.
>     Reporter: Ryan Christanson
>     Priority: Minor
>  Attachments: interaction.patch, patch.txt
>
> I've attached a patch to the commons-jelly-tags-interaction jar. This
> patch makes it so the interaction task will try to use jline:
> http://jline.sourceforge.net/
> Jline makes it so a java console will have tab completion, and
> history, and other goodies.
> This is great, because the maven-console plugin uses the
> commons-jelly-tags-interaction jar. So if you update the
> commons-jelly-tags-interaction jar, and then tell the maven console
> plugin to use the new jar, then your maven console will have history,
> and tab completion.
> I've set it up to remember all of the commands typed in any console,
> further it uses that history as the tab completion source - so you can
> tab complete past commands.
> I've tested this in windows and it works great, but in windows with
> cygwin, it doesn't do the fancy completion, but still works.
> By the way, in windows, jline's lib doesn't support arrows for
> history, so use CONTROL+P and CONTROL+N.
> Its possible that there might be a better way to integrate jline into
> this lib, i've just done what looked like the quickest way to get it
> working so my maven console would have history and tab completion.
> Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (JELLY-175) patch for jelly-tags-interaction

Posted by "Lukas Theussl (JIRA)" <co...@jakarta.apache.org>.
    [ http://issues.apache.org/jira/browse/JELLY-175?page=comments#action_12378525 ] 

Lukas Theussl commented on JELLY-175:
-------------------------------------

Done: see JELLY-229

> patch for jelly-tags-interaction
> --------------------------------
>
>          Key: JELLY-175
>          URL: http://issues.apache.org/jira/browse/JELLY-175
>      Project: Jelly
>         Type: Improvement

>  Environment: I've tested this in windows with and without cygwin.
>     Reporter: Ryan Christanson
>     Priority: Minor
>  Attachments: interaction.patch, patch.txt
>
> I've attached a patch to the commons-jelly-tags-interaction jar. This
> patch makes it so the interaction task will try to use jline:
> http://jline.sourceforge.net/
> Jline makes it so a java console will have tab completion, and
> history, and other goodies.
> This is great, because the maven-console plugin uses the
> commons-jelly-tags-interaction jar. So if you update the
> commons-jelly-tags-interaction jar, and then tell the maven console
> plugin to use the new jar, then your maven console will have history,
> and tab completion.
> I've set it up to remember all of the commands typed in any console,
> further it uses that history as the tab completion source - so you can
> tab complete past commands.
> I've tested this in windows and it works great, but in windows with
> cygwin, it doesn't do the fancy completion, but still works.
> By the way, in windows, jline's lib doesn't support arrows for
> history, so use CONTROL+P and CONTROL+N.
> Its possible that there might be a better way to integrate jline into
> this lib, i've just done what looked like the quickest way to get it
> working so my maven console would have history and tab completion.
> Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (JELLY-175) patch for jelly-tags-interaction

Posted by "Lukas Theussl (JIRA)" <co...@jakarta.apache.org>.
    [ http://issues.apache.org/jira/browse/JELLY-175?page=comments#action_12378351 ] 

Lukas Theussl commented on JELLY-175:
-------------------------------------

I did _not_ apply the patch. As I said above, the patch has been applied a long time ago (http://svn.apache.org/viewcvs.cgi?rev=148941&view=rev), it is included in the current svn trunk. 

For the problems you experience, it's weird indeed. Maybe a Mac specific issue as the reporter above affirms he has also tested it on Windows?

> patch for jelly-tags-interaction
> --------------------------------
>
>          Key: JELLY-175
>          URL: http://issues.apache.org/jira/browse/JELLY-175
>      Project: Jelly
>         Type: Improvement

>  Environment: I've tested this in windows with and without cygwin.
>     Reporter: Ryan Christanson
>     Priority: Minor
>  Attachments: interaction.patch, patch.txt
>
> I've attached a patch to the commons-jelly-tags-interaction jar. This
> patch makes it so the interaction task will try to use jline:
> http://jline.sourceforge.net/
> Jline makes it so a java console will have tab completion, and
> history, and other goodies.
> This is great, because the maven-console plugin uses the
> commons-jelly-tags-interaction jar. So if you update the
> commons-jelly-tags-interaction jar, and then tell the maven console
> plugin to use the new jar, then your maven console will have history,
> and tab completion.
> I've set it up to remember all of the commands typed in any console,
> further it uses that history as the tab completion source - so you can
> tab complete past commands.
> I've tested this in windows and it works great, but in windows with
> cygwin, it doesn't do the fancy completion, but still works.
> By the way, in windows, jline's lib doesn't support arrows for
> history, so use CONTROL+P and CONTROL+N.
> Its possible that there might be a better way to integrate jline into
> this lib, i've just done what looked like the quickest way to get it
> working so my maven console would have history and tab completion.
> Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (JELLY-175) patch for jelly-tags-interaction

Posted by "dion gillard (JIRA)" <co...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/JELLY-175?page=comments#action_57623 ]
     
dion gillard commented on JELLY-175:
------------------------------------

I'm still unsure if we can *use* LGPL binaries in ASF code. Note: we wont be distributing it.

> patch for jelly-tags-interaction
> --------------------------------
>
>          Key: JELLY-175
>          URL: http://issues.apache.org/jira/browse/JELLY-175
>      Project: jelly
>         Type: Improvement
>  Environment: I've tested this in windows with and without cygwin.
>     Reporter: Ryan Christanson
>     Priority: Minor
>  Attachments: patch.txt
>
> I've attached a patch to the commons-jelly-tags-interaction jar. This
> patch makes it so the interaction task will try to use jline:
> http://jline.sourceforge.net/
> Jline makes it so a java console will have tab completion, and
> history, and other goodies.
> This is great, because the maven-console plugin uses the
> commons-jelly-tags-interaction jar. So if you update the
> commons-jelly-tags-interaction jar, and then tell the maven console
> plugin to use the new jar, then your maven console will have history,
> and tab completion.
> I've set it up to remember all of the commands typed in any console,
> further it uses that history as the tab completion source - so you can
> tab complete past commands.
> I've tested this in windows and it works great, but in windows with
> cygwin, it doesn't do the fancy completion, but still works.
> By the way, in windows, jline's lib doesn't support arrows for
> history, so use CONTROL+P and CONTROL+N.
> Its possible that there might be a better way to integrate jline into
> this lib, i've just done what looked like the quickest way to get it
> working so my maven console would have history and tab completion.
> Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Resolved: (JELLY-175) patch for jelly-tags-interaction

Posted by "Paul Libbrecht (JIRA)" <co...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/JELLY-175?page=all ]
     
Paul Libbrecht resolved JELLY-175:
----------------------------------

    Resolution: Fixed

This in the current version about to be released (I think).
paul

> patch for jelly-tags-interaction
> --------------------------------
>
>          Key: JELLY-175
>          URL: http://issues.apache.org/jira/browse/JELLY-175
>      Project: Jelly
>         Type: Improvement

>   Components: taglib.interaction
>     Versions: 1.0
>  Environment: I've tested this in windows with and without cygwin.
>     Reporter: Ryan Christanson
>     Assignee: Paul Libbrecht
>     Priority: Minor
>      Fix For: 1.1
>  Attachments: interaction.patch, patch.txt
>
> I've attached a patch to the commons-jelly-tags-interaction jar. This
> patch makes it so the interaction task will try to use jline:
> http://jline.sourceforge.net/
> Jline makes it so a java console will have tab completion, and
> history, and other goodies.
> This is great, because the maven-console plugin uses the
> commons-jelly-tags-interaction jar. So if you update the
> commons-jelly-tags-interaction jar, and then tell the maven console
> plugin to use the new jar, then your maven console will have history,
> and tab completion.
> I've set it up to remember all of the commands typed in any console,
> further it uses that history as the tab completion source - so you can
> tab complete past commands.
> I've tested this in windows and it works great, but in windows with
> cygwin, it doesn't do the fancy completion, but still works.
> By the way, in windows, jline's lib doesn't support arrows for
> history, so use CONTROL+P and CONTROL+N.
> Its possible that there might be a better way to integrate jline into
> this lib, i've just done what looked like the quickest way to get it
> working so my maven console would have history and tab completion.
> Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (JELLY-175) patch for jelly-tags-interaction

Posted by "Brett Porter (JIRA)" <co...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/JELLY-175?page=comments#action_57985 ]
     
Brett Porter commented on JELLY-175:
------------------------------------

As of 0.9.0, jline is now BSD-licensed. We can go ahead with this.


> patch for jelly-tags-interaction
> --------------------------------
>
>          Key: JELLY-175
>          URL: http://issues.apache.org/jira/browse/JELLY-175
>      Project: jelly
>         Type: Improvement
>  Environment: I've tested this in windows with and without cygwin.
>     Reporter: Ryan Christanson
>     Priority: Minor
>  Attachments: patch.txt
>
> I've attached a patch to the commons-jelly-tags-interaction jar. This
> patch makes it so the interaction task will try to use jline:
> http://jline.sourceforge.net/
> Jline makes it so a java console will have tab completion, and
> history, and other goodies.
> This is great, because the maven-console plugin uses the
> commons-jelly-tags-interaction jar. So if you update the
> commons-jelly-tags-interaction jar, and then tell the maven console
> plugin to use the new jar, then your maven console will have history,
> and tab completion.
> I've set it up to remember all of the commands typed in any console,
> further it uses that history as the tab completion source - so you can
> tab complete past commands.
> I've tested this in windows and it works great, but in windows with
> cygwin, it doesn't do the fancy completion, but still works.
> By the way, in windows, jline's lib doesn't support arrows for
> history, so use CONTROL+P and CONTROL+N.
> Its possible that there might be a better way to integrate jline into
> this lib, i've just done what looked like the quickest way to get it
> working so my maven console would have history and tab completion.
> Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (JELLY-175) patch for jelly-tags-interaction

Posted by "Paul Libbrecht (JIRA)" <co...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/JELLY-175?page=comments#action_58187 ]
     
Paul Libbrecht commented on JELLY-175:
--------------------------------------

Tried to applied the patch but got again some errors, even after translating the end of lines.

Ryan, could you try to produce the patch again with cvs diff -u > patch2.txt ?

Reading a bit of the source code, it looks like there's more potential of JLine that could be used there!
In particular, I would believe it would be very helpful for maven to provide to the ask-tag the list of possible completions from the set of goals... in one sentence... there's some future!

paul

> patch for jelly-tags-interaction
> --------------------------------
>
>          Key: JELLY-175
>          URL: http://issues.apache.org/jira/browse/JELLY-175
>      Project: jelly
>         Type: Improvement
>  Environment: I've tested this in windows with and without cygwin.
>     Reporter: Ryan Christanson
>     Priority: Minor
>  Attachments: patch.txt
>
> I've attached a patch to the commons-jelly-tags-interaction jar. This
> patch makes it so the interaction task will try to use jline:
> http://jline.sourceforge.net/
> Jline makes it so a java console will have tab completion, and
> history, and other goodies.
> This is great, because the maven-console plugin uses the
> commons-jelly-tags-interaction jar. So if you update the
> commons-jelly-tags-interaction jar, and then tell the maven console
> plugin to use the new jar, then your maven console will have history,
> and tab completion.
> I've set it up to remember all of the commands typed in any console,
> further it uses that history as the tab completion source - so you can
> tab complete past commands.
> I've tested this in windows and it works great, but in windows with
> cygwin, it doesn't do the fancy completion, but still works.
> By the way, in windows, jline's lib doesn't support arrows for
> history, so use CONTROL+P and CONTROL+N.
> Its possible that there might be a better way to integrate jline into
> this lib, i've just done what looked like the quickest way to get it
> working so my maven console would have history and tab completion.
> Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (JELLY-175) patch for jelly-tags-interaction

Posted by "Paul Libbrecht (JIRA)" <co...@jakarta.apache.org>.
    [ http://issues.apache.org/jira/browse/JELLY-175?page=comments#action_12378339 ] 

Paul Libbrecht commented on JELLY-175:
--------------------------------------

Very weird, I did the same (you should have also indicated you applied the patch).
And... well... I get a very bad result, namely... that maven console just forgets to ask... ie. as if if was EOF...
Platform: MacOSX 10.3.9

paul

> patch for jelly-tags-interaction
> --------------------------------
>
>          Key: JELLY-175
>          URL: http://issues.apache.org/jira/browse/JELLY-175
>      Project: Jelly
>         Type: Improvement

>  Environment: I've tested this in windows with and without cygwin.
>     Reporter: Ryan Christanson
>     Priority: Minor
>  Attachments: interaction.patch, patch.txt
>
> I've attached a patch to the commons-jelly-tags-interaction jar. This
> patch makes it so the interaction task will try to use jline:
> http://jline.sourceforge.net/
> Jline makes it so a java console will have tab completion, and
> history, and other goodies.
> This is great, because the maven-console plugin uses the
> commons-jelly-tags-interaction jar. So if you update the
> commons-jelly-tags-interaction jar, and then tell the maven console
> plugin to use the new jar, then your maven console will have history,
> and tab completion.
> I've set it up to remember all of the commands typed in any console,
> further it uses that history as the tab completion source - so you can
> tab complete past commands.
> I've tested this in windows and it works great, but in windows with
> cygwin, it doesn't do the fancy completion, but still works.
> By the way, in windows, jline's lib doesn't support arrows for
> history, so use CONTROL+P and CONTROL+N.
> Its possible that there might be a better way to integrate jline into
> this lib, i've just done what looked like the quickest way to get it
> working so my maven console would have history and tab completion.
> Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (JELLY-175) patch for jelly-tags-interaction

Posted by "Paul Libbrecht (JIRA)" <co...@jakarta.apache.org>.
    [ http://issues.apache.org/jira/browse/JELLY-175?page=comments#action_12378292 ] 

Paul Libbrecht commented on JELLY-175:
--------------------------------------

Please be more precise as to how this works great for you (platform, how built-in, example code, etc...). 
Last I tried, precisely the maven embedding did not work.

thanks
paul

> patch for jelly-tags-interaction
> --------------------------------
>
>          Key: JELLY-175
>          URL: http://issues.apache.org/jira/browse/JELLY-175
>      Project: Jelly
>         Type: Improvement

>  Environment: I've tested this in windows with and without cygwin.
>     Reporter: Ryan Christanson
>     Priority: Minor
>  Attachments: interaction.patch, patch.txt
>
> I've attached a patch to the commons-jelly-tags-interaction jar. This
> patch makes it so the interaction task will try to use jline:
> http://jline.sourceforge.net/
> Jline makes it so a java console will have tab completion, and
> history, and other goodies.
> This is great, because the maven-console plugin uses the
> commons-jelly-tags-interaction jar. So if you update the
> commons-jelly-tags-interaction jar, and then tell the maven console
> plugin to use the new jar, then your maven console will have history,
> and tab completion.
> I've set it up to remember all of the commands typed in any console,
> further it uses that history as the tab completion source - so you can
> tab complete past commands.
> I've tested this in windows and it works great, but in windows with
> cygwin, it doesn't do the fancy completion, but still works.
> By the way, in windows, jline's lib doesn't support arrows for
> history, so use CONTROL+P and CONTROL+N.
> Its possible that there might be a better way to integrate jline into
> this lib, i've just done what looked like the quickest way to get it
> working so my maven console would have history and tab completion.
> Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (JELLY-175) patch for jelly-tags-interaction

Posted by "Paul Libbrecht (JIRA)" <co...@jakarta.apache.org>.
    [ http://issues.apache.org/jira/browse/JELLY-175?page=comments#action_12378439 ] 

Paul Libbrecht commented on JELLY-175:
--------------------------------------

I suppose I was too tired...
I did it again... indeed saw that the patch was not needed... and that I got it working on my Mac.
This ability to change the dependency of an installed plugin is quite amazing, I have to say.

By working, I could only test inputting goals, going left and right, and bringing last input goals in... that's already nice.
It'd be nicer that the list of goals is added as possible completions... any reason not to try to add a method such as setCompletor(list) allowing a <i:ask completor="${list}" answer="a"/> ?

paul

> patch for jelly-tags-interaction
> --------------------------------
>
>          Key: JELLY-175
>          URL: http://issues.apache.org/jira/browse/JELLY-175
>      Project: Jelly
>         Type: Improvement

>  Environment: I've tested this in windows with and without cygwin.
>     Reporter: Ryan Christanson
>     Priority: Minor
>  Attachments: interaction.patch, patch.txt
>
> I've attached a patch to the commons-jelly-tags-interaction jar. This
> patch makes it so the interaction task will try to use jline:
> http://jline.sourceforge.net/
> Jline makes it so a java console will have tab completion, and
> history, and other goodies.
> This is great, because the maven-console plugin uses the
> commons-jelly-tags-interaction jar. So if you update the
> commons-jelly-tags-interaction jar, and then tell the maven console
> plugin to use the new jar, then your maven console will have history,
> and tab completion.
> I've set it up to remember all of the commands typed in any console,
> further it uses that history as the tab completion source - so you can
> tab complete past commands.
> I've tested this in windows and it works great, but in windows with
> cygwin, it doesn't do the fancy completion, but still works.
> By the way, in windows, jline's lib doesn't support arrows for
> history, so use CONTROL+P and CONTROL+N.
> Its possible that there might be a better way to integrate jline into
> this lib, i've just done what looked like the quickest way to get it
> working so my maven console would have history and tab completion.
> Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (JELLY-175) patch for jelly-tags-interaction

Posted by "Paul Libbrecht (JIRA)" <co...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/JELLY-175?page=all ]

Paul Libbrecht updated JELLY-175:
---------------------------------

      Component: taglib.interaction
    Fix Version: 1.1
        Version: 1.0
      Assign To: Paul Libbrecht

Fixed versions component.

> patch for jelly-tags-interaction
> --------------------------------
>
>          Key: JELLY-175
>          URL: http://issues.apache.org/jira/browse/JELLY-175
>      Project: Jelly
>         Type: Improvement

>   Components: taglib.interaction
>     Versions: 1.0
>  Environment: I've tested this in windows with and without cygwin.
>     Reporter: Ryan Christanson
>     Assignee: Paul Libbrecht
>     Priority: Minor
>      Fix For: 1.1
>  Attachments: interaction.patch, patch.txt
>
> I've attached a patch to the commons-jelly-tags-interaction jar. This
> patch makes it so the interaction task will try to use jline:
> http://jline.sourceforge.net/
> Jline makes it so a java console will have tab completion, and
> history, and other goodies.
> This is great, because the maven-console plugin uses the
> commons-jelly-tags-interaction jar. So if you update the
> commons-jelly-tags-interaction jar, and then tell the maven console
> plugin to use the new jar, then your maven console will have history,
> and tab completion.
> I've set it up to remember all of the commands typed in any console,
> further it uses that history as the tab completion source - so you can
> tab complete past commands.
> I've tested this in windows and it works great, but in windows with
> cygwin, it doesn't do the fancy completion, but still works.
> By the way, in windows, jline's lib doesn't support arrows for
> history, so use CONTROL+P and CONTROL+N.
> Its possible that there might be a better way to integrate jline into
> this lib, i've just done what looked like the quickest way to get it
> working so my maven console would have history and tab completion.
> Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (JELLY-175) patch for jelly-tags-interaction

Posted by "Ryan Christianson (JIRA)" <co...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/JELLY-175?page=comments#action_58229 ]
     
Ryan Christianson commented on JELLY-175:
-----------------------------------------

Im looking at why the patch didnt work, ill report back in a bit.

> patch for jelly-tags-interaction
> --------------------------------
>
>          Key: JELLY-175
>          URL: http://issues.apache.org/jira/browse/JELLY-175
>      Project: jelly
>         Type: Improvement
>  Environment: I've tested this in windows with and without cygwin.
>     Reporter: Ryan Christanson
>     Priority: Minor
>  Attachments: patch.txt
>
> I've attached a patch to the commons-jelly-tags-interaction jar. This
> patch makes it so the interaction task will try to use jline:
> http://jline.sourceforge.net/
> Jline makes it so a java console will have tab completion, and
> history, and other goodies.
> This is great, because the maven-console plugin uses the
> commons-jelly-tags-interaction jar. So if you update the
> commons-jelly-tags-interaction jar, and then tell the maven console
> plugin to use the new jar, then your maven console will have history,
> and tab completion.
> I've set it up to remember all of the commands typed in any console,
> further it uses that history as the tab completion source - so you can
> tab complete past commands.
> I've tested this in windows and it works great, but in windows with
> cygwin, it doesn't do the fancy completion, but still works.
> By the way, in windows, jline's lib doesn't support arrows for
> history, so use CONTROL+P and CONTROL+N.
> Its possible that there might be a better way to integrate jline into
> this lib, i've just done what looked like the quickest way to get it
> working so my maven console would have history and tab completion.
> Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (JELLY-175) patch for jelly-tags-interaction

Posted by "Brett Porter (JIRA)" <co...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/JELLY-175?page=comments#action_57712 ]
     
Brett Porter commented on JELLY-175:
------------------------------------

I've contacted the author, as the docs suggest that he is open to other licensing. The project hasn't been touched in a year and a half, so we'll see. Hopefully he is still around and interested in opening up the license a little so it can be included.

> patch for jelly-tags-interaction
> --------------------------------
>
>          Key: JELLY-175
>          URL: http://issues.apache.org/jira/browse/JELLY-175
>      Project: jelly
>         Type: Improvement
>  Environment: I've tested this in windows with and without cygwin.
>     Reporter: Ryan Christanson
>     Priority: Minor
>  Attachments: patch.txt
>
> I've attached a patch to the commons-jelly-tags-interaction jar. This
> patch makes it so the interaction task will try to use jline:
> http://jline.sourceforge.net/
> Jline makes it so a java console will have tab completion, and
> history, and other goodies.
> This is great, because the maven-console plugin uses the
> commons-jelly-tags-interaction jar. So if you update the
> commons-jelly-tags-interaction jar, and then tell the maven console
> plugin to use the new jar, then your maven console will have history,
> and tab completion.
> I've set it up to remember all of the commands typed in any console,
> further it uses that history as the tab completion source - so you can
> tab complete past commands.
> I've tested this in windows and it works great, but in windows with
> cygwin, it doesn't do the fancy completion, but still works.
> By the way, in windows, jline's lib doesn't support arrows for
> history, so use CONTROL+P and CONTROL+N.
> Its possible that there might be a better way to integrate jline into
> this lib, i've just done what looked like the quickest way to get it
> working so my maven console would have history and tab completion.
> Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (JELLY-175) patch for jelly-tags-interaction

Posted by "Lukas Theussl (JIRA)" <co...@jakarta.apache.org>.
    [ http://issues.apache.org/jira/browse/JELLY-175?page=comments#action_12378299 ] 

Lukas Theussl commented on JELLY-175:
-------------------------------------

Paul,
First, thanks for your feedback and interest, I was really afraid that jelly folks are dying out!

Now here is what I did:
- grabbed the jelly-tags-interaction code from svn, build a jar and put it in my local maven repo
- in the console plugin, changed the jelly-tags-interaction dependency to 1.1-SNAPSHOT and added a dependency on jline 0.9.0
- installed the plugin - voila

I ran a couple of standard goals (jar, test, site..) in console mode and verified that history and tab completion works as described above (great!).
I don't know what other 'goodies' are being referred to, I am not familiar with the jline library.

My system setup: Linux FC3, JDK 1.4.2_10, maven-1.1-beta-3 (current development version).

Cheers,
Lukas

> patch for jelly-tags-interaction
> --------------------------------
>
>          Key: JELLY-175
>          URL: http://issues.apache.org/jira/browse/JELLY-175
>      Project: Jelly
>         Type: Improvement

>  Environment: I've tested this in windows with and without cygwin.
>     Reporter: Ryan Christanson
>     Priority: Minor
>  Attachments: interaction.patch, patch.txt
>
> I've attached a patch to the commons-jelly-tags-interaction jar. This
> patch makes it so the interaction task will try to use jline:
> http://jline.sourceforge.net/
> Jline makes it so a java console will have tab completion, and
> history, and other goodies.
> This is great, because the maven-console plugin uses the
> commons-jelly-tags-interaction jar. So if you update the
> commons-jelly-tags-interaction jar, and then tell the maven console
> plugin to use the new jar, then your maven console will have history,
> and tab completion.
> I've set it up to remember all of the commands typed in any console,
> further it uses that history as the tab completion source - so you can
> tab complete past commands.
> I've tested this in windows and it works great, but in windows with
> cygwin, it doesn't do the fancy completion, but still works.
> By the way, in windows, jline's lib doesn't support arrows for
> history, so use CONTROL+P and CONTROL+N.
> Its possible that there might be a better way to integrate jline into
> this lib, i've just done what looked like the quickest way to get it
> working so my maven console would have history and tab completion.
> Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (JELLY-175) patch for jelly-tags-interaction

Posted by "Lukas Theussl (JIRA)" <co...@jakarta.apache.org>.
    [ http://issues.apache.org/jira/browse/JELLY-175?page=comments#action_12378162 ] 

Lukas Theussl commented on JELLY-175:
-------------------------------------

This patch has been applied more than a year ago. I have tested it with the maven console plugin and it works great. I'd like to include this in the next release of the console plugin, is there any chance that jelly-tags-interaction 1.1 could be released any time soon? (Assuming there are still some Jelly devs reading this...)

> patch for jelly-tags-interaction
> --------------------------------
>
>          Key: JELLY-175
>          URL: http://issues.apache.org/jira/browse/JELLY-175
>      Project: Jelly
>         Type: Improvement

>  Environment: I've tested this in windows with and without cygwin.
>     Reporter: Ryan Christanson
>     Priority: Minor
>  Attachments: interaction.patch, patch.txt
>
> I've attached a patch to the commons-jelly-tags-interaction jar. This
> patch makes it so the interaction task will try to use jline:
> http://jline.sourceforge.net/
> Jline makes it so a java console will have tab completion, and
> history, and other goodies.
> This is great, because the maven-console plugin uses the
> commons-jelly-tags-interaction jar. So if you update the
> commons-jelly-tags-interaction jar, and then tell the maven console
> plugin to use the new jar, then your maven console will have history,
> and tab completion.
> I've set it up to remember all of the commands typed in any console,
> further it uses that history as the tab completion source - so you can
> tab complete past commands.
> I've tested this in windows and it works great, but in windows with
> cygwin, it doesn't do the fancy completion, but still works.
> By the way, in windows, jline's lib doesn't support arrows for
> history, so use CONTROL+P and CONTROL+N.
> Its possible that there might be a better way to integrate jline into
> this lib, i've just done what looked like the quickest way to get it
> working so my maven console would have history and tab completion.
> Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (JELLY-175) patch for jelly-tags-interaction

Posted by "Ryan Christanson (JIRA)" <co...@jakarta.apache.org>.
     [ http://nagoya.apache.org/jira/browse/JELLY-175?page=history ]

Ryan Christanson updated JELLY-175:
-----------------------------------

    Attachment: patch.txt

here is the patch to add jline support

> patch for jelly-tags-interaction
> --------------------------------
>
>          Key: JELLY-175
>          URL: http://nagoya.apache.org/jira/browse/JELLY-175
>      Project: jelly
>         Type: Improvement
>  Environment: I've tested this in windows with and without cygwin.
>     Reporter: Ryan Christanson
>     Priority: Minor
>  Attachments: patch.txt
>
> I've attached a patch to the commons-jelly-tags-interaction jar. This
> patch makes it so the interaction task will try to use jline:
> http://jline.sourceforge.net/
> Jline makes it so a java console will have tab completion, and
> history, and other goodies.
> This is great, because the maven-console plugin uses the
> commons-jelly-tags-interaction jar. So if you update the
> commons-jelly-tags-interaction jar, and then tell the maven console
> plugin to use the new jar, then your maven console will have history,
> and tab completion.
> I've set it up to remember all of the commands typed in any console,
> further it uses that history as the tab completion source - so you can
> tab complete past commands.
> I've tested this in windows and it works great, but in windows with
> cygwin, it doesn't do the fancy completion, but still works.
> By the way, in windows, jline's lib doesn't support arrows for
> history, so use CONTROL+P and CONTROL+N.
> Its possible that there might be a better way to integrate jline into
> this lib, i've just done what looked like the quickest way to get it
> working so my maven console would have history and tab completion.
> Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (JELLY-175) patch for jelly-tags-interaction

Posted by "Paul Libbrecht (JIRA)" <co...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/JELLY-175?page=comments#action_57644 ]
     
Paul Libbrecht commented on JELLY-175:
--------------------------------------

I think the situation sounds pretty delicate and that currently linking to LGPL is not a good idea. See:
  http://wiki.apache.org/jakarta/Using_20LGPL_27d_20code

It seems that the ASF and the FSF are currently trying to resolve this.

paul

> patch for jelly-tags-interaction
> --------------------------------
>
>          Key: JELLY-175
>          URL: http://issues.apache.org/jira/browse/JELLY-175
>      Project: jelly
>         Type: Improvement
>  Environment: I've tested this in windows with and without cygwin.
>     Reporter: Ryan Christanson
>     Priority: Minor
>  Attachments: patch.txt
>
> I've attached a patch to the commons-jelly-tags-interaction jar. This
> patch makes it so the interaction task will try to use jline:
> http://jline.sourceforge.net/
> Jline makes it so a java console will have tab completion, and
> history, and other goodies.
> This is great, because the maven-console plugin uses the
> commons-jelly-tags-interaction jar. So if you update the
> commons-jelly-tags-interaction jar, and then tell the maven console
> plugin to use the new jar, then your maven console will have history,
> and tab completion.
> I've set it up to remember all of the commands typed in any console,
> further it uses that history as the tab completion source - so you can
> tab complete past commands.
> I've tested this in windows and it works great, but in windows with
> cygwin, it doesn't do the fancy completion, but still works.
> By the way, in windows, jline's lib doesn't support arrows for
> history, so use CONTROL+P and CONTROL+N.
> Its possible that there might be a better way to integrate jline into
> this lib, i've just done what looked like the quickest way to get it
> working so my maven console would have history and tab completion.
> Maybe this feature could be enabled with a tag attribute?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org