You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Ádám Bakai (Code Review)" <ge...@cloudera.org> on 2023/11/21 09:38:15 UTC
[kudu-CR] [ExternalMiniCluster] Improve leader master retrieval
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20714
to look at the new patch set (#4).
Change subject: [ExternalMiniCluster] Improve leader master retrieval
......................................................................
[ExternalMiniCluster] Improve leader master retrieval
ExternalMiniCluster::leader_master() function was improved to use the RPC.
However during the dns_alias_itest cases, the host that was stored in the
masters_[]->bound_rpc_hostport was a domain name, and the RPC returns IP
address and they are compared as strings. This made leader_master() check
in ExternalMiniCluster::AddTabletServer() fail. The solution is that
bound_rpc_hostport values are converted to Sockaddr and compared to the
leader_master_addr that is retrieved from the ConnectToClusterRpc.
Change-Id: I4a40fa8e9513066d08b42eefc57a04ba90bded82
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
2 files changed, 21 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/20714/4
--
To view, visit http://gerrit.cloudera.org:8080/20714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4a40fa8e9513066d08b42eefc57a04ba90bded82
Gerrit-Change-Number: 20714
Gerrit-PatchSet: 4
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)