You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "ctubbsii (via GitHub)" <gi...@apache.org> on 2023/12/07 00:51:23 UTC
[PR] Fix issues with LogEntryTest [accumulo]
ctubbsii opened a new pull request, #4035:
URL: https://github.com/apache/accumulo/pull/4035
* Make constants private
* Use SimpleImmutableMap instead of anonymous inner class
* Include getFilePath method in testEquals
* Test all methods using the constructor
* Test all methods using fromMetaWalEntry
* Remove testing of invalid "foo" path that wasn't actually read
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix issues with LogEntryTest [accumulo]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii merged PR #4035:
URL: https://github.com/apache/accumulo/pull/4035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix issues with LogEntryTest [accumulo]
Posted by "rsingh433 (via GitHub)" <gi...@apache.org>.
rsingh433 commented on PR #4035:
URL: https://github.com/apache/accumulo/pull/4035#issuecomment-1845734929
Thank you for fixing this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix issues with LogEntryTest [accumulo]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #4035:
URL: https://github.com/apache/accumulo/pull/4035#issuecomment-1843959419
Thanks to @keith-turner for helping me make sense of the existing test. I'm still not sure what the original test was trying to cover overall... it just seemed to be testing random things. I rewrote it so it made a bit more sense. This should help with #3997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org