[PATCH] WOOPS (Was RE: EmbededTomcat.java requires jsse)

["Stefan F. Stefansson" <st...@decode.is>]

Woopsie... I have to take this one on me... sorry guys.

Well... that's what you get when you let bozos like me mess with your
code ;o)

Costin: you were right... all it took was what you mentioned.  I've
changed the file and it's compiling. I've done a little testing on it
and it seems to be working ok.  At least it's compiling (with and
without JSSE jars in the classpath) and it's making the secure endpoints
correctly (when compiled with JSSE.  If you don't compile tomcat with
JSSE you can't make the secure endpoints but that's normal and ok).  I
haven't done any exhaustive testing and I don't know when/if I'm gonna
have time to do that, but I've done a little testing and everything
seems to be working fine.

In the meantime, here is the updated file and once again... I'm really
sorry about this.

Kind regards, Stefan Freyr


-----Original Message-----
From: Costin Manolache [mailto:cmanolache@yahoo.com]
Sent: 22. november 2000 01:18
To: tomcat-dev@jakarta.apache.org
Subject: Re: EmbededTomcat.java requires jsse


I don't like that - tomcat is supposed to depend
only on JDK1.1  and a minimal number of extensions
( jaxp is the only required extension ).

All non-jdk1.1, non-standard extensions can be used,
but shouldn't be required to build standalone tomcat.

I don't know if it's too late to change this - it
seems 
we just need to replace 

   sc.setSocketFactory(new
org.apache.tomcat.net.SSLSocketFactory());

with 
 	sc.setAttribute( "socketFactory", 			
"org.apache.tomcat.net.SSLSocketFactory");

and remove the import line.

I know it's not the the easiest solution, but I think
it's worth the added complexity - it is still a
requirement to support JDK1.1 and work with a minimal
set of library ( and JSSE is a very special one
anyway, export, etc).

Costin

--- Mike Anderson <MM...@novell.com> wrote:
> I updated my source from CVS yesterday and all of
> the sudden I couldn't build.  I got an error saying
> javax.net.ServeSocketFactory not found in import
> when trying to build
>
src\share\org\apache\tomcat\net\SSLSocketFactory.java.
>  I looked at the build.xml and it looked like it
> shouldn't even be trying to build
> SSLSocketFactory.java since I didn't have the jsse
> classes in my classpath.  However, looking in the
> EmbededTomcat.java that was checked in on 11/17, it
> now does an import of org.apache.tomcat.net.* and
> directly references
> org.apache.tomcat.net.SSLSocketFactory.  Is there a
> way to fix this or are we now going to need to add
> the jsse jars to the build classpath?  If I do need
> to add the jsse jars, we should probably update the
> README to mention this so that others don't pull
> their hair out like I did for a while today.
> 
> Thanks,
> 
> Mike Anderson
> Senior Software Engineer
> Platform Services Group
> mmanders@novell.com
> Novell, Inc., the leading provider of Net services
> software
> www.novell.com
> 


__________________________________________________
Do You Yahoo!?
Yahoo! Shopping - Thousands of Stores. Millions of Products.
http://shopping.yahoo.com/

Re: [PATCH] WOOPS (Was RE: EmbededTomcat.java requires jsse)

[cm...@yahoo.com]

> Well... that's what you get when you let bozos like me mess with your
> code ;o)

No problem, we are very happy to see people messing with tomcat ! 


Costin