You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "fallintoplace (via GitHub)" <gi...@apache.org> on 2026/08/01 16:55:49 UTC

[PR] fix(arrow): avoid retains on invalid chunk construction [arrow-go]

fallintoplace opened a new pull request, #1078:
URL: https://github.com/apache/arrow-go/pull/1078

   ## Problem
   
   NewChunked retained each valid chunk as it iterated. If a later chunk had a mismatched datatype, construction panicked while the earlier retains remained outstanding. A caller that recovered and released its own arrays could not free their buffers.
   
   ## Change
   
   Validate all non-nil chunk datatypes before retaining any input. Successful construction keeps the existing ownership behavior, while invalid construction leaves every input reference unchanged.
   
   ## Coverage
   
   The regression test uses a checked allocator and a mismatched second chunk. After recovering from the expected panic and releasing the caller-owned arrays, allocator usage must return to zero.
   
   ## Validation
   
   - go test ./arrow/array
   - go test -race ./arrow/array -run '^TestChunkedInvalidReleasesNoExtraReferences$' -count=1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(arrow): avoid retains on invalid chunk construction [arrow-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #1078:
URL: https://github.com/apache/arrow-go/pull/1078


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org