[jira] [Work logged] (AVRO-3327) Use Pattern Matching to avoid is check followed by cast

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AVRO-3327?focusedWorklogId=716024&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716024 ]

ASF GitHub Bot logged work on AVRO-3327:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Jan/22 21:24
            Start Date: 26/Jan/22 21:24
    Worklog Time Spent: 10m 
      Work Description: KyleSchoonover opened a new pull request #1478:
URL: https://github.com/apache/avro/pull/1478


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-3327
   
   ### Tests
   
   - [ ] My PR does not need testing for this extremely good reason: Non functional change
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 716024)
    Remaining Estimate: 0h
            Time Spent: 10m

> Use Pattern Matching to avoid is check followed by cast
> -------------------------------------------------------
>
>                 Key: AVRO-3327
>                 URL: https://issues.apache.org/jira/browse/AVRO-3327
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: csharp
>    Affects Versions: 1.11.1
>            Reporter: Kyle Schoonover
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {code:java}
> return (obj is AvroDecimal) && Equals((AvroDecimal)obj); {code}
> In the current code we are checking obj to see if it is in fact an AvroDecimal, then we cast it for the next check (technically creating a new variable in memory).  Since we have already validated it's value type there is no need to cast it.
> Suggested Change:
> {code:java}
> return (obj is AvroDecimal @decimal) && Equals(@decimal); {code}
>  
> Pattern Matching Overview: [Pattern matching overview - C# guide | Microsoft Docs|https://docs.microsoft.com/en-us/dotnet/csharp/fundamentals/functional/pattern-matching]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)