You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bert Huijben <be...@qqmail.nl> on 2016/10/17 14:29:23 UTC
RE: svn commit: r1765286 - in /subversion/trunk/subversion: include/svn_xml.h libsvn_subr/xml.c tests/libsvn_subr/xml-test.c
> -----Original Message-----
> From: ivan@apache.org [mailto:ivan@apache.org]
> Sent: maandag 17 oktober 2016 15:49
> To: commits@subversion.apache.org
> Subject: svn commit: r1765286 - in /subversion/trunk/subversion:
> include/svn_xml.h libsvn_subr/xml.c tests/libsvn_subr/xml-test.c
>
> Author: ivan
> Date: Mon Oct 17 13:49:05 2016
> New Revision: 1765286
>
> URL: http://svn.apache.org/viewvc?rev=1765286&view=rev
> Log:
> Implement standard lifetime semantics for svn_xml_parser_t: the object will be
> automatically freed on pool cleanup. But it still can be freed explicitly
> using svn_xml_free_parser(). It's the same behavior we already have for
> svn_sqlite__db_t and similar.
Are you planning a new use of this api?
It is currently only used by subversion/libsvn_wc/old-and-busted.c, and I don't think we should really spend time optimizing that specific usecase (reading pre 1.4 working copies)
Bert
Re: svn commit: r1765286 - in /subversion/trunk/subversion:
include/svn_xml.h libsvn_subr/xml.c tests/libsvn_subr/xml-test.c
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On 17 October 2016 at 17:29, Bert Huijben <be...@qqmail.nl> wrote:
>> -----Original Message-----
>> From: ivan@apache.org [mailto:ivan@apache.org]
>> Sent: maandag 17 oktober 2016 15:49
>> To: commits@subversion.apache.org
>> Subject: svn commit: r1765286 - in /subversion/trunk/subversion:
>> include/svn_xml.h libsvn_subr/xml.c tests/libsvn_subr/xml-test.c
>>
>> Author: ivan
>> Date: Mon Oct 17 13:49:05 2016
>> New Revision: 1765286
>>
>> URL: http://svn.apache.org/viewvc?rev=1765286&view=rev
>> Log:
>> Implement standard lifetime semantics for svn_xml_parser_t: the object will be
>> automatically freed on pool cleanup. But it still can be freed explicitly
>> using svn_xml_free_parser(). It's the same behavior we already have for
>> svn_sqlite__db_t and similar.
>
> Are you planning a new use of this api?
>
Yes. Currently we link Expat XML three times: in libsvn_subr,
libsvn_ra_serf and mod_dontdothat. I'd like to fix it.
> It is currently only used by subversion/libsvn_wc/old-and-busted.c, and I don't
> think we should really spend time optimizing that specific usecase (reading pre 1.4 working copies)
>
Of course I'm aware of this.
--
Ivan Zhakov