You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/13 03:24:12 UTC

[GitHub] [incubator-doris] mrhhsg opened a new pull request, #8994: [Fix]Crash caused by adding mem_tracker in get_next

mrhhsg opened a new pull request, #8994:
URL: https://github.com/apache/incubator-doris/pull/8994

   # Proposed changes
   
   Issue Number: close #8993 
   
   ## Problem Summary:
   
   Describe the overview of changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior:  NO
   2. Has unit tests been added: No Need
   3. Has document been added or modified: No Need
   4. Does it need to update dependencies: No
   5. Are there any changes that cannot be rolled back: No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] xinyiZzz commented on a diff in pull request #8994: [Fix]Crash caused by adding mem_tracker in get_next

Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on code in PR #8994:
URL: https://github.com/apache/incubator-doris/pull/8994#discussion_r851163533


##########
be/src/vec/exec/vexchange_node.cpp:
##########
@@ -73,6 +73,8 @@ Status VExchangeNode::open(RuntimeState* state) {
         RETURN_IF_ERROR(_stream_recvr->create_merger(_vsort_exec_exprs.lhs_ordering_expr_ctxs(),
                                                      _is_asc_order, _nulls_first,
                                                      state->batch_size(), _limit, _offset));
+    } else {
+        ADD_THREAD_LOCAL_MEM_TRACKER(_stream_recvr->mem_tracker());

Review Comment:
   Thx for your fix,
   Is the crash in the first line of `thread_mem_tracker_mgr.h::add_tracker` `DCHECK(_mem_trackers.find(mem_tracker->id()) == _mem_trackers.end());`?
   
   I'm working on a complete fix for this, and this DCHECK may be commented out shortly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] mrhhsg commented on a diff in pull request #8994: [Fix]Crash caused by adding mem_tracker in get_next

Posted by GitBox <gi...@apache.org>.
mrhhsg commented on code in PR #8994:
URL: https://github.com/apache/incubator-doris/pull/8994#discussion_r851194612


##########
be/src/vec/exec/vexchange_node.cpp:
##########
@@ -73,6 +73,8 @@ Status VExchangeNode::open(RuntimeState* state) {
         RETURN_IF_ERROR(_stream_recvr->create_merger(_vsort_exec_exprs.lhs_ordering_expr_ctxs(),
                                                      _is_asc_order, _nulls_first,
                                                      state->batch_size(), _limit, _offset));
+    } else {
+        ADD_THREAD_LOCAL_MEM_TRACKER(_stream_recvr->mem_tracker());

Review Comment:
   Yes, and I will close the PR since you are working on it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] mrhhsg closed pull request #8994: [Fix]Crash caused by adding mem_tracker in get_next

Posted by GitBox <gi...@apache.org>.
mrhhsg closed pull request #8994: [Fix]Crash caused by adding mem_tracker in get_next
URL: https://github.com/apache/incubator-doris/pull/8994


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org