You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/02/05 22:05:59 UTC
Review Request 43261: Refactor process::initialize environment
variable parsing into Flags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43261/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.
Bugs: MESOS-4609
https://issues.apache.org/jira/browse/MESOS-4609
Repository: mesos
Description
-------
Moves the environment variables `LIBPROCESS_` + (`IP`, `ADVERTISE_IP`, `PORT`, `ADVERTISE_PORT`) into a Flags object along with the validation logic for ports. Help strings of the flags are synced with the docs in configuration.md.
Diffs
-----
3rdparty/libprocess/src/process.cpp 4a5302085917db14654a2f942d85261b934473f7
Diff: https://reviews.apache.org/r/43261/diff/
Testing
-------
make check (OSX)
Thanks,
Joseph Wu
Re: Review Request 43261: Refactor process::initialize environment
variable parsing into Flags.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43261/#review118104
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43260, 43261]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 5, 2016, 9:05 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43261/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 9:05 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.
>
>
> Bugs: MESOS-4609
> https://issues.apache.org/jira/browse/MESOS-4609
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves the environment variables `LIBPROCESS_` + (`IP`, `ADVERTISE_IP`, `PORT`, `ADVERTISE_PORT`) into a Flags object along with the validation logic for ports. Help strings of the flags are synced with the docs in configuration.md.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 4a5302085917db14654a2f942d85261b934473f7
>
> Diff: https://reviews.apache.org/r/43261/diff/
>
>
> Testing
> -------
>
> make check (OSX)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 43261: Refactor process::initialize environment
variable parsing into Flags.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43261/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 11:09 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.
Bugs: MESOS-4609
https://issues.apache.org/jira/browse/MESOS-4609
Repository: mesos
Description
-------
Moves the environment variables `LIBPROCESS_` + (`IP`, `ADVERTISE_IP`, `PORT`, `ADVERTISE_PORT`) into a Flags object along with the validation logic for ports. Help strings of the flags are synced with the docs in configuration.md.
Diffs
-----
3rdparty/libprocess/src/process.cpp 4a5302085917db14654a2f942d85261b934473f7
Diff: https://reviews.apache.org/r/43261/diff/
Testing
-------
make check (OSX)
Thanks,
Joseph Wu
Re: Review Request 43261: Refactor process::initialize environment
variable parsing into Flags.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43261/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 11:08 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.
Bugs: MESOS-4609
https://issues.apache.org/jira/browse/MESOS-4609
Repository: mesos
Description
-------
Moves the environment variables `LIBPROCESS_` + (`IP`, `ADVERTISE_IP`, `PORT`, `ADVERTISE_PORT`) into a Flags object along with the validation logic for ports. Help strings of the flags are synced with the docs in configuration.md.
Diffs
-----
3rdparty/libprocess/src/process.cpp 4a5302085917db14654a2f942d85261b934473f7
Diff: https://reviews.apache.org/r/43261/diff/
Testing
-------
make check (OSX)
Thanks,
Joseph Wu
Re: Review Request 43261: Refactor process::initialize environment
variable parsing into Flags.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43261/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 11:08 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.
Changes
-------
testing depends on. -- @vinodkone
Bugs: MESOS-4609
https://issues.apache.org/jira/browse/MESOS-4609
Repository: mesos
Description
-------
Moves the environment variables `LIBPROCESS_` + (`IP`, `ADVERTISE_IP`, `PORT`, `ADVERTISE_PORT`) into a Flags object along with the validation logic for ports. Help strings of the flags are synced with the docs in configuration.md.
Diffs
-----
3rdparty/libprocess/src/process.cpp 4a5302085917db14654a2f942d85261b934473f7
Diff: https://reviews.apache.org/r/43261/diff/
Testing
-------
make check (OSX)
Thanks,
Joseph Wu