[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1252: HDDS-4010. S3G startup fails when multiple service ids are configured.

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #1252:
URL: https://github.com/apache/hadoop-ozone/pull/1252#discussion_r461838645



##########
File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneServiceProvider.java
##########
@@ -49,34 +49,24 @@
 
   @PostConstruct
   public void init() {
-    Collection<String> serviceIdList =
-        conf.getTrimmedStringCollection(OZONE_OM_SERVICE_IDS_KEY);
-    if (serviceIdList.size() == 0) {
-      // Non-HA cluster
+    try {
+      omserviceID = OmUtils.getOzoneManagerServiceId(conf);
+    } catch (IOException ex) {
+      throw new ConfigurationException(ex.getMessage(), ex);

Review comment:
       When it has more than one service id, it will fail only when internal service id is not configured.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org