You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/08 12:06:58 UTC

[GitHub] [flink] fpompermaier commented on pull request #12036: [FLINK-17537][connectors / jdbc] Refactor flink-jdbc connector structure

fpompermaier commented on pull request #12036:
URL: https://github.com/apache/flink/pull/12036#issuecomment-625783987


   Just two notes: since you are refactoring the entire JDBC connector I have collected 2 observations from the other PR I have opened:
   
   - made by @aljoscha on pull #11986 for FLINK-17361: the usage of StreamITCase.clear() in JDBCTableSourceITCase.java is an anti-pattern that should be avoided
   - made by me on pull #12038 and #11999: in all methods in JDBCDialect.java it would be better to have the tableName parameter as an object on which we can extract **schema** and the non-qualified **tableName**, in order to avoid to wrongly quote table names. In those PR I removed the quoteIdentifier(tableName) within the getMergeIntoStatement() but I think the same principle applies also to other methods such as getInsertIntoStatement() or getRowExistsStatement().


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org