You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/10/08 21:29:39 UTC
Re: Review Request 29551: Added "tests" target for make.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/
-----------------------------------------------------------
(Updated Oct. 8, 2015, 3:29 p.m.)
Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, and Timothy St. Clair.
Bugs: MESOS-2273
https://issues.apache.org/jira/browse/MESOS-2273
Repository: mesos
Description
-------
'make check' allows one to build and run the test suite. However,
'make tests' allows one to build the test suite without running it.
Diffs (updated)
-----
3rdparty/Makefile.am 7c244a053044ae347f9505cb78a71a6636e26586
Makefile.am cb289b4f21516c3027429d8f8ba72d799f975bd4
src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
Diff: https://reviews.apache.org/r/29551/diff/
Testing
-------
Ran 'make tests'.
For added test, ran "make clean; make; make tests" followed by "make check" and verified that no additional target are build in the "make check" step.
Thanks,
Kapil Arya
Re: Review Request 29551: Added "tests" target for make.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/#review102711
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29550, 29551]
All tests passed.
- Mesos ReviewBot
On Oct. 14, 2015, 6:31 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29551/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 6:31 p.m.)
>
>
> Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, and Timothy St. Clair.
>
>
> Bugs: MESOS-2273
> https://issues.apache.org/jira/browse/MESOS-2273
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 'make check' allows one to build and run the test suite. However,
> 'make tests' allows one to build the test suite without running it.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 7c244a053044ae347f9505cb78a71a6636e26586
> Makefile.am cb289b4f21516c3027429d8f8ba72d799f975bd4
> docs/submitting-a-patch.md cbd99fe3fd162703165933336700e3fc292243a9
> src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e
>
> Diff: https://reviews.apache.org/r/29551/diff/
>
>
> Testing
> -------
>
> Ran 'make tests'.
>
> For added test, ran "make clean; make; make tests" followed by "make check" and verified that no additional target are build in the "make check" step.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 29551: Added "tests" target for make.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/#review103027
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Oct. 14, 2015, 6:31 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29551/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 6:31 p.m.)
>
>
> Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, and Timothy St. Clair.
>
>
> Bugs: MESOS-2273
> https://issues.apache.org/jira/browse/MESOS-2273
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 'make check' allows one to build and run the test suite. However,
> 'make tests' allows one to build the test suite without running it.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 7c244a053044ae347f9505cb78a71a6636e26586
> Makefile.am cb289b4f21516c3027429d8f8ba72d799f975bd4
> docs/submitting-a-patch.md cbd99fe3fd162703165933336700e3fc292243a9
> src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e
>
> Diff: https://reviews.apache.org/r/29551/diff/
>
>
> Testing
> -------
>
> Ran 'make tests'.
>
> For added test, ran "make clean; make; make tests" followed by "make check" and verified that no additional target are build in the "make check" step.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 29551: Added "tests" target for make.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/
-----------------------------------------------------------
(Updated Oct. 14, 2015, 2:31 p.m.)
Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, and Timothy St. Clair.
Changes
-------
rebased
Bugs: MESOS-2273
https://issues.apache.org/jira/browse/MESOS-2273
Repository: mesos
Description
-------
'make check' allows one to build and run the test suite. However,
'make tests' allows one to build the test suite without running it.
Diffs (updated)
-----
3rdparty/Makefile.am 7c244a053044ae347f9505cb78a71a6636e26586
Makefile.am cb289b4f21516c3027429d8f8ba72d799f975bd4
docs/submitting-a-patch.md cbd99fe3fd162703165933336700e3fc292243a9
src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e
Diff: https://reviews.apache.org/r/29551/diff/
Testing
-------
Ran 'make tests'.
For added test, ran "make clean; make; make tests" followed by "make check" and verified that no additional target are build in the "make check" step.
Thanks,
Kapil Arya
Re: Review Request 29551: Added "tests" target for make.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/#review102004
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39138, 29550, 29551]
All tests passed.
- Mesos ReviewBot
On Oct. 8, 2015, 8:21 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29551/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 8:21 p.m.)
>
>
> Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, and Timothy St. Clair.
>
>
> Bugs: MESOS-2273
> https://issues.apache.org/jira/browse/MESOS-2273
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 'make check' allows one to build and run the test suite. However,
> 'make tests' allows one to build the test suite without running it.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 7c244a053044ae347f9505cb78a71a6636e26586
> Makefile.am cb289b4f21516c3027429d8f8ba72d799f975bd4
> docs/submitting-a-patch.md 78ffcfbe74c78abf3cd9d77234f9b61dd29f2ca4
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
>
> Diff: https://reviews.apache.org/r/29551/diff/
>
>
> Testing
> -------
>
> Ran 'make tests'.
>
> For added test, ran "make clean; make; make tests" followed by "make check" and verified that no additional target are build in the "make check" step.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 29551: Added "tests" target for make.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/
-----------------------------------------------------------
(Updated Oct. 8, 2015, 4:21 p.m.)
Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, and Timothy St. Clair.
Changes
-------
Updated submitting-a-patch.md file as well.
Bugs: MESOS-2273
https://issues.apache.org/jira/browse/MESOS-2273
Repository: mesos
Description
-------
'make check' allows one to build and run the test suite. However,
'make tests' allows one to build the test suite without running it.
Diffs (updated)
-----
3rdparty/Makefile.am 7c244a053044ae347f9505cb78a71a6636e26586
Makefile.am cb289b4f21516c3027429d8f8ba72d799f975bd4
docs/submitting-a-patch.md 78ffcfbe74c78abf3cd9d77234f9b61dd29f2ca4
src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
Diff: https://reviews.apache.org/r/29551/diff/
Testing
-------
Ran 'make tests'.
For added test, ran "make clean; make; make tests" followed by "make check" and verified that no additional target are build in the "make check" step.
Thanks,
Kapil Arya
Re: Review Request 29551: Added "tests" target for make.
Posted by Kapil Arya <ka...@mesosphere.io>.
> On Oct. 8, 2015, 4:15 p.m., Neil Conway wrote:
> > Can you update the docs to mention this? Maybe just submitting-a-patch.
Done! :-)
- Kapil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/#review101953
-----------------------------------------------------------
On Oct. 8, 2015, 4:21 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29551/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 4:21 p.m.)
>
>
> Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, and Timothy St. Clair.
>
>
> Bugs: MESOS-2273
> https://issues.apache.org/jira/browse/MESOS-2273
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 'make check' allows one to build and run the test suite. However,
> 'make tests' allows one to build the test suite without running it.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 7c244a053044ae347f9505cb78a71a6636e26586
> Makefile.am cb289b4f21516c3027429d8f8ba72d799f975bd4
> docs/submitting-a-patch.md 78ffcfbe74c78abf3cd9d77234f9b61dd29f2ca4
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
>
> Diff: https://reviews.apache.org/r/29551/diff/
>
>
> Testing
> -------
>
> Ran 'make tests'.
>
> For added test, ran "make clean; make; make tests" followed by "make check" and verified that no additional target are build in the "make check" step.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 29551: Added "tests" target for make.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/#review101953
-----------------------------------------------------------
Can you update the docs to mention this? Maybe just submitting-a-patch.
- Neil Conway
On Oct. 8, 2015, 7:29 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29551/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 7:29 p.m.)
>
>
> Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, and Timothy St. Clair.
>
>
> Bugs: MESOS-2273
> https://issues.apache.org/jira/browse/MESOS-2273
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 'make check' allows one to build and run the test suite. However,
> 'make tests' allows one to build the test suite without running it.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 7c244a053044ae347f9505cb78a71a6636e26586
> Makefile.am cb289b4f21516c3027429d8f8ba72d799f975bd4
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
>
> Diff: https://reviews.apache.org/r/29551/diff/
>
>
> Testing
> -------
>
> Ran 'make tests'.
>
> For added test, ran "make clean; make; make tests" followed by "make check" and verified that no additional target are build in the "make check" step.
>
>
> Thanks,
>
> Kapil Arya
>
>