[GitHub] [spark] HyukjinKwon commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)

[GitBox <gi...@apache.org>]

HyukjinKwon commented on issue #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#issuecomment-582685622
 
 
   > If we start to support more queries in this file, we need to bring them back.
   > Let's not decide what is not required at this stage.
   
   @dongjoon-hyun, the flip side also works. For the time we don't support, we can save one INSERT and CREATE operation in test base until that point. I don't think keeping unused data or codes in test cases is right. We should bring it back only when it's used. (e.g., we should remove unused codes rather then keeping it just in case it's used in the future).
   
   Just to be clear, is this inconsistent with other ported tests in PostgreSQL? If that's the case, let's revive; otherwise, I think we can just go ahead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org