You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@httpd.apache.org by Christopher Schultz <ch...@christopherschultz.net> on 2016/12/28 22:44:49 UTC
[users@httpd] Copyright notices in httpd source files
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
All,
Is it common to have a copyright notice in httpd C source files?
Jim committed a donation of code for HAProxy's PROXY protocol in
r1776076 and later. (Thanks, by the way: I've been hoping to get this
in 2.4 for a while so consider me a big (karma-less) +1 for back-port
of this module).
The C source
https://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_prox
y_protocol.c?view=markup&pathrev=1776076
file contains this copyright claim:
Copyright 2014 Cloudzilla Inc.
I haven't pulled the source to see if other such claims exist in other
source files, but I have never noticed a copyright claim in other ASF
projects.
Is this a simple oversight or should the copyright notice remain?
Thanks,
- -chris
PS Special thanks to Dan Ruggeri who was working on this independently
of the donation with me, and who missed his own commit of virtually
the same code by a few hours.
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBCAAGBQJYZEBhAAoJEBzwKT+lPKRYMTQQALHTwsO8Xba/UtAxKoh7lwhj
Uwh/J61NR21okbb+1Kl3I3kCXAqBs61gKkEAvVZYCVIPkO6tSFW/zSlVWsebC0GD
erM9BLAk8UHfD5gEI3i6JwP+umbYleLQJOcbGbLObG6sOfsdKHcMQJ3jl2mNCFCJ
QozZQy4BQBjCw9GA5n9QJBVA04vYBAG4IKCgD6UqtrKp+9AJzfNv0fjkAHx+X6Jo
Ec5YtRsvO7hj6341C3UxgBpw/+rPZxXWeJVvVekVfsFzjxvJGpnJQV/Yx3iGvaGn
uwdnLXLAgNFs82N/ip9GZNbv12jPFzUvu7WxXG9PXHZ5z9oL2y4s1m95RsVLPATn
zViFxZkGTF4h1rdqix2MNN7/q/hQmY6XsOo1fSlSAYhAMFQ1g43EMecLud3dCECw
ypjVVJO+T29JArCzyJb5skOr2lSdcf9ZYAhnStgHmRUw/bvwDhcMaCjsdqFdaUSD
fIqMdp7gAJ3/fou/AdARERxhR7UNDp7sNJcCpOo/hoHoJ8QSy5b7CBUGG3uemdjH
JBPYtYVilbvif7/EV9AAWwsKO/JX4smqctHrU2ZG/JHt0f4pQ+QxaTkys+jblXdu
83ROK+0DlX9KXcIOSBQ/SWqj/3UoPIgVxXgnf8RKztMuUUdFrPScWYpKFPpoeXPF
5+VNuOdIkoX+MalGusox
=wMXF
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@httpd.apache.org
For additional commands, e-mail: users-help@httpd.apache.org
Re: [users@httpd] Copyright notices in httpd source files
Posted by Dr James Smith <js...@sanger.ac.uk>.
At work all out software is open source - but we have to include a
copyright notice in all source files where possible - as we then
distribute the content under LGPL. The logic is that if we didn't claim
copyright on the contents of the source - someone else might claim it
and make it closed source.
On 28/12/2016 22:44, Christopher Schultz wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> All,
>
> Is it common to have a copyright notice in httpd C source files?
>
> Jim committed a donation of code for HAProxy's PROXY protocol in
> r1776076 and later. (Thanks, by the way: I've been hoping to get this
> in 2.4 for a while so consider me a big (karma-less) +1 for back-port
> of this module).
>
> The C source
> https://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_prox
> y_protocol.c?view=markup&pathrev=1776076
> file contains this copyright claim:
>
> Copyright 2014 Cloudzilla Inc.
>
> I haven't pulled the source to see if other such claims exist in other
> source files, but I have never noticed a copyright claim in other ASF
> projects.
>
> Is this a simple oversight or should the copyright notice remain?
>
> Thanks,
> - -chris
>
> PS Special thanks to Dan Ruggeri who was working on this independently
> of the donation with me, and who missed his own commit of virtually
> the same code by a few hours.
> -----BEGIN PGP SIGNATURE-----
> Comment: GPGTools - http://gpgtools.org
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQIcBAEBCAAGBQJYZEBhAAoJEBzwKT+lPKRYMTQQALHTwsO8Xba/UtAxKoh7lwhj
> Uwh/J61NR21okbb+1Kl3I3kCXAqBs61gKkEAvVZYCVIPkO6tSFW/zSlVWsebC0GD
> erM9BLAk8UHfD5gEI3i6JwP+umbYleLQJOcbGbLObG6sOfsdKHcMQJ3jl2mNCFCJ
> QozZQy4BQBjCw9GA5n9QJBVA04vYBAG4IKCgD6UqtrKp+9AJzfNv0fjkAHx+X6Jo
> Ec5YtRsvO7hj6341C3UxgBpw/+rPZxXWeJVvVekVfsFzjxvJGpnJQV/Yx3iGvaGn
> uwdnLXLAgNFs82N/ip9GZNbv12jPFzUvu7WxXG9PXHZ5z9oL2y4s1m95RsVLPATn
> zViFxZkGTF4h1rdqix2MNN7/q/hQmY6XsOo1fSlSAYhAMFQ1g43EMecLud3dCECw
> ypjVVJO+T29JArCzyJb5skOr2lSdcf9ZYAhnStgHmRUw/bvwDhcMaCjsdqFdaUSD
> fIqMdp7gAJ3/fou/AdARERxhR7UNDp7sNJcCpOo/hoHoJ8QSy5b7CBUGG3uemdjH
> JBPYtYVilbvif7/EV9AAWwsKO/JX4smqctHrU2ZG/JHt0f4pQ+QxaTkys+jblXdu
> 83ROK+0DlX9KXcIOSBQ/SWqj/3UoPIgVxXgnf8RKztMuUUdFrPScWYpKFPpoeXPF
> 5+VNuOdIkoX+MalGusox
> =wMXF
> -----END PGP SIGNATURE-----
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@httpd.apache.org
> For additional commands, e-mail: users-help@httpd.apache.org
>
--
The Wellcome Trust Sanger Institute is operated by Genome Research
Limited, a charity registered in England with number 1021457 and a
company registered in England with number 2742969, whose registered
office is 215 Euston Road, London, NW1 2BE.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@httpd.apache.org
For additional commands, e-mail: users-help@httpd.apache.org
Re: [users@httpd] Copyright notices in httpd source files
Posted by Christopher Schultz <ch...@christopherschultz.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Jim,
On 12/29/16 9:38 AM, Jim Jagielski wrote:
> I didn't know you guys were working on it. Cool. I had been working
> the donation angle for awhile and finally got approval so wanted to
> get it in quick! :)
Daniel's efforts were focused on a patch to mod_remoteip which IMO
seems more natural (though I'm largely ignorant of how anything
"should" be done within httpd, so take my opinion with zero gravity of
course) rather than a separate module.
I'll join the dev@ list where we could probably continue this
discussion with a better audience.
Thanks,
- -chris
>> On Dec 29, 2016, at 3:56 AM, Nick Kew <ni...@apache.org> wrote:
>>
>> Cc: dev list. Looks like a catch?
>>
>> On Wed, 2016-12-28 at 17:44 -0500, Christopher Schultz wrote:
>>> All,
>>>
>>> Is it common to have a copyright notice in httpd C source
>>> files?
>>
>> Not common, but neither is it unusual. I'd expect it to mean
>> someone else copyrighted it before contributing it to apache.
>>
>>> [ mod_proxy_protocol.c ] Copyright 2014 Cloudzilla Inc.
>>
>> If that's in our svn, it should probably have another line
>> asserting Apache copyright alongside that one. As in, for
>> instance, mod_proxy_html.
>>
>> -- Nick Kew
>>
>
>
> ---------------------------------------------------------------------
>
>
To unsubscribe, e-mail: users-unsubscribe@httpd.apache.org
> For additional commands, e-mail: users-help@httpd.apache.org
>
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBCAAGBQJYZeQGAAoJEBzwKT+lPKRY90QP/jnoTj/LlmUV0YveVpyX13jZ
ysxx1HJarxMM6ePOVh/6KCkgwWYGe6SH0MyFrxUwrmH4BkZkXors3u/TJZFfWR9P
kru1Z9c+9doPWGPAXZZz/cQrHU6dvDFp8LIs4uPXlb+p2DrsHizGZnZxta9ckqa/
lTdHgUbcpVP1e8YV2S8bBi5SuV3tmf97IN5GV7wi/G9EtQlcFWQ7NH+dYDs62TlU
emr9Xo2hAGfVhaYKZ9wHcLgjuVXRhHnl1UM7YpiReSvsNwpX+a+kLEf7B3iYdE1t
fk80HCWHmmcOe21nOIyU/OsyUVyVd2be64aH6gzrnh5yxIayb3ZSB8+eyk1O+aoR
LA8fVAJgiDonj7JS/d7DSHkImIK5PIvD6voDMCQ2Rf0DSf6DlFGKC96yKUbIUC5O
5MGym7n+j6WxaiUHReBZaAeW/gcwnzr7xqe+PRXBmBQmlJrVPmdpM6nNjyxOn6Bn
ylw9pmO99lC+qUO01rY/duHhMrQY+SDnCxyGx1xdAYK7ASSAw7gtUU3Zfvoe27zo
XT33d8XsBTXsMFDeOBLz9Nws2qnHQQ4BOSV8+s7sio1IVeV2F32T9RPEIu7J/TCN
WZsWBy7NS2BvGVjezgOGMhVZnl81Y+HsPrU7ZCKmIKEpkJGMWnopmtUhMrs9X7Yv
+bo4j01/FrMGpNna4RCI
=RuJT
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@httpd.apache.org
For additional commands, e-mail: users-help@httpd.apache.org
Re: [users@httpd] Copyright notices in httpd source files
Posted by Jim Jagielski <ji...@jaguNET.com>.
I didn't know you guys were working on it. Cool. I had
been working the donation angle for awhile and finally
got approval so wanted to get it in quick! :)
> On Dec 29, 2016, at 3:56 AM, Nick Kew <ni...@apache.org> wrote:
>
> Cc: dev list. Looks like a catch?
>
> On Wed, 2016-12-28 at 17:44 -0500, Christopher Schultz wrote:
>> All,
>>
>> Is it common to have a copyright notice in httpd C source files?
>
> Not common, but neither is it unusual. I'd expect it to mean
> someone else copyrighted it before contributing it to apache.
>
>> [ mod_proxy_protocol.c ]
>> Copyright 2014 Cloudzilla Inc.
>
> If that's in our svn, it should probably have another line
> asserting Apache copyright alongside that one. As in,
> for instance, mod_proxy_html.
>
> --
> Nick Kew
>
Re: [users@httpd] Copyright notices in httpd source files
Posted by Christopher Schultz <ch...@christopherschultz.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Nick,
On 12/29/16 3:56 AM, Nick Kew wrote:
> Cc: dev list. Looks like a catch?
(my reply might be bounced from the dev@ list... I don't think I'm
subscribed)
> On Wed, 2016-12-28 at 17:44 -0500, Christopher Schultz wrote:
>> All,
>>
>> Is it common to have a copyright notice in httpd C source files?
>
> Not common, but neither is it unusual. I'd expect it to mean
> someone else copyrighted it before contributing it to apache.
>
>> [ mod_proxy_protocol.c ] Copyright 2014 Cloudzilla Inc.
>
> If that's in our svn, it should probably have another line
> asserting Apache copyright alongside that one. As in, for
> instance, mod_proxy_html.
Yep, this is ASF svn. That's why I included the link in my original post
:
https://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_prox
y_protocol.c?view=markup&pathrev=1776076
- -chris
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBCAAGBQJYZeM4AAoJEBzwKT+lPKRYpN4P/30FjhTLL1iMSVRETFzQkBsC
T+7e8+0NejwaqSoAqWpX/VbIawgyGFtsqgFjqOzGkp8Oy3FSnWpCFfG3IVR/4DCW
dEe+/LWU5f+B0T1dJyDL2DOCxnHQPiyPc3AYGF+NUtIvKEys8m7zO8hTQ0Dz5TFB
k4GFt69aP+MJnKAQAx8T1Gilwbu5vUZWmxu80rbl85FixYiW3iTSPHzApQ53ZSdx
mUUHYoV9wv0fwm1+Udj6SHQRkVDBmzwddeTdqEa9mukdf6zc+8R4pcx8K0YLxuMP
iduKLbXCxpy2oi28UpqqD8/5JD9adNBc3aYUpm0b/7ceJpr05wkFtZfh7OerULwr
nYqxaZtogrdMPzV3fgOvz2S136uqDd0qSFOyvV7Qy8i/87Yr+kkk1GDaVcenhM1m
z6+0iV9ftm5F4QbivheaKsJJEut4urfiVBnUha1l+BveWO+IOR047U/gdP7gfvcP
RrCqaYLSclCP0UtlBAa0RWlZSsa4HS3/m+YyJ/dm4pDbjY6kyWAkA8w4+GOJhQLf
MJ//TKbZ9LGNo4ueye+pRN1H4OFuJqTI1c4LdOsXqOW62IhATUIU8/DNCxKrlkTL
pGp2C+5qUDQGj/yotEdyI9oDshm3ZDgPAplMQcl2itVyKgKYVrjmHfgLectRNAKf
m+W8ul5tp4Dp0N0vJSU1
=Uymx
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@httpd.apache.org
For additional commands, e-mail: users-help@httpd.apache.org
Re: [users@httpd] Copyright notices in httpd source files
Posted by Jim Jagielski <ji...@jaguNET.com>.
I didn't know you guys were working on it. Cool. I had
been working the donation angle for awhile and finally
got approval so wanted to get it in quick! :)
> On Dec 29, 2016, at 3:56 AM, Nick Kew <ni...@apache.org> wrote:
>
> Cc: dev list. Looks like a catch?
>
> On Wed, 2016-12-28 at 17:44 -0500, Christopher Schultz wrote:
>> All,
>>
>> Is it common to have a copyright notice in httpd C source files?
>
> Not common, but neither is it unusual. I'd expect it to mean
> someone else copyrighted it before contributing it to apache.
>
>> [ mod_proxy_protocol.c ]
>> Copyright 2014 Cloudzilla Inc.
>
> If that's in our svn, it should probably have another line
> asserting Apache copyright alongside that one. As in,
> for instance, mod_proxy_html.
>
> --
> Nick Kew
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@httpd.apache.org
For additional commands, e-mail: users-help@httpd.apache.org
Re: [users@httpd] Copyright notices in httpd source files
Posted by Christopher Schultz <ch...@christopherschultz.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Nick,
On 12/29/16 3:56 AM, Nick Kew wrote:
> Cc: dev list. Looks like a catch?
(my reply might be bounced from the dev@ list... I don't think I'm
subscribed)
> On Wed, 2016-12-28 at 17:44 -0500, Christopher Schultz wrote:
>> All,
>>
>> Is it common to have a copyright notice in httpd C source files?
>
> Not common, but neither is it unusual. I'd expect it to mean
> someone else copyrighted it before contributing it to apache.
>
>> [ mod_proxy_protocol.c ] Copyright 2014 Cloudzilla Inc.
>
> If that's in our svn, it should probably have another line
> asserting Apache copyright alongside that one. As in, for
> instance, mod_proxy_html.
Yep, this is ASF svn. That's why I included the link in my original post
:
https://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_prox
y_protocol.c?view=markup&pathrev=1776076
- -chris
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBCAAGBQJYZeM4AAoJEBzwKT+lPKRYpN4P/30FjhTLL1iMSVRETFzQkBsC
T+7e8+0NejwaqSoAqWpX/VbIawgyGFtsqgFjqOzGkp8Oy3FSnWpCFfG3IVR/4DCW
dEe+/LWU5f+B0T1dJyDL2DOCxnHQPiyPc3AYGF+NUtIvKEys8m7zO8hTQ0Dz5TFB
k4GFt69aP+MJnKAQAx8T1Gilwbu5vUZWmxu80rbl85FixYiW3iTSPHzApQ53ZSdx
mUUHYoV9wv0fwm1+Udj6SHQRkVDBmzwddeTdqEa9mukdf6zc+8R4pcx8K0YLxuMP
iduKLbXCxpy2oi28UpqqD8/5JD9adNBc3aYUpm0b/7ceJpr05wkFtZfh7OerULwr
nYqxaZtogrdMPzV3fgOvz2S136uqDd0qSFOyvV7Qy8i/87Yr+kkk1GDaVcenhM1m
z6+0iV9ftm5F4QbivheaKsJJEut4urfiVBnUha1l+BveWO+IOR047U/gdP7gfvcP
RrCqaYLSclCP0UtlBAa0RWlZSsa4HS3/m+YyJ/dm4pDbjY6kyWAkA8w4+GOJhQLf
MJ//TKbZ9LGNo4ueye+pRN1H4OFuJqTI1c4LdOsXqOW62IhATUIU8/DNCxKrlkTL
pGp2C+5qUDQGj/yotEdyI9oDshm3ZDgPAplMQcl2itVyKgKYVrjmHfgLectRNAKf
m+W8ul5tp4Dp0N0vJSU1
=Uymx
-----END PGP SIGNATURE-----
Re: [users@httpd] Copyright notices in httpd source files
Posted by Nick Kew <ni...@apache.org>.
Cc: dev list. Looks like a catch?
On Wed, 2016-12-28 at 17:44 -0500, Christopher Schultz wrote:
> All,
>
> Is it common to have a copyright notice in httpd C source files?
Not common, but neither is it unusual. I'd expect it to mean
someone else copyrighted it before contributing it to apache.
> [ mod_proxy_protocol.c ]
> Copyright 2014 Cloudzilla Inc.
If that's in our svn, it should probably have another line
asserting Apache copyright alongside that one. As in,
for instance, mod_proxy_html.
--
Nick Kew
Re: [users@httpd] Copyright notices in httpd source files
Posted by Nick Kew <ni...@apache.org>.
Cc: dev list. Looks like a catch?
On Wed, 2016-12-28 at 17:44 -0500, Christopher Schultz wrote:
> All,
>
> Is it common to have a copyright notice in httpd C source files?
Not common, but neither is it unusual. I'd expect it to mean
someone else copyrighted it before contributing it to apache.
> [ mod_proxy_protocol.c ]
> Copyright 2014 Cloudzilla Inc.
If that's in our svn, it should probably have another line
asserting Apache copyright alongside that one. As in,
for instance, mod_proxy_html.
--
Nick Kew
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@httpd.apache.org
For additional commands, e-mail: users-help@httpd.apache.org