You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Mark Hobson <ma...@gmail.com> on 2007/06/08 10:19:46 UTC
Re: svn commit: r545241 - /maven/components/trunk/maven-project/src/test/java/org/apache/maven/project/AbstractMavenProjectTestCase.java
On 07/06/07, jdcasey@apache.org <jd...@apache.org> wrote:
> Author: jdcasey
> Date: Thu Jun 7 09:54:58 2007
> New Revision: 545241
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=545241
> Log:
> Replacing JDK 1.5 api call.
>
> Modified:
> maven/components/trunk/maven-project/src/test/java/org/apache/maven/project/AbstractMavenProjectTestCase.java
>
> Modified: maven/components/trunk/maven-project/src/test/java/org/apache/maven/project/AbstractMavenProjectTestCase.java
> URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-project/src/test/java/org/apache/maven/project/AbstractMavenProjectTestCase.java?view=diff&rev=545241&r1=545240&r2=545241
> ==============================================================================
> --- maven/components/trunk/maven-project/src/test/java/org/apache/maven/project/AbstractMavenProjectTestCase.java (original)
> +++ maven/components/trunk/maven-project/src/test/java/org/apache/maven/project/AbstractMavenProjectTestCase.java Thu Jun 7 09:54:58 2007
> @@ -27,6 +27,7 @@
>
> import java.io.File;
> import java.io.FileNotFoundException;
> +import java.net.URI;
> import java.net.URISyntaxException;
> import java.net.URL;
>
> @@ -79,7 +80,7 @@
> throw new FileNotFoundException( "Unable to find: " + resource );
> }
>
> - return new File( resourceUrl.toURI() );
> + return new File( new URI( resourceUrl.getPath() ) );
Shouldn't that be: new URI( resourceUrl.toString() ) to match the JDK5
implementation?
> }
>
> protected ArtifactRepository getLocalRepository()
Cheers,
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r545241 - /maven/components/trunk/maven-project/src/test/java/org/apache/maven/project/AbstractMavenProjectTestCase.java
Posted by John Casey <jd...@commonjava.org>.
done, thanks for the catch.
-john
On Jun 8, 2007, at 4:19 AM, Mark Hobson wrote:
> On 07/06/07, jdcasey@apache.org <jd...@apache.org> wrote:
>> Author: jdcasey
>> Date: Thu Jun 7 09:54:58 2007
>> New Revision: 545241
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=545241
>> Log:
>> Replacing JDK 1.5 api call.
>>
>> Modified:
>> maven/components/trunk/maven-project/src/test/java/org/apache/
>> maven/project/AbstractMavenProjectTestCase.java
>>
>> Modified: maven/components/trunk/maven-project/src/test/java/org/
>> apache/maven/project/AbstractMavenProjectTestCase.java
>> URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-
>> project/src/test/java/org/apache/maven/project/
>> AbstractMavenProjectTestCase.java?
>> view=diff&rev=545241&r1=545240&r2=545241
>> =====================================================================
>> =========
>> --- maven/components/trunk/maven-project/src/test/java/org/apache/
>> maven/project/AbstractMavenProjectTestCase.java (original)
>> +++ maven/components/trunk/maven-project/src/test/java/org/apache/
>> maven/project/AbstractMavenProjectTestCase.java Thu Jun 7
>> 09:54:58 2007
>> @@ -27,6 +27,7 @@
>>
>> import java.io.File;
>> import java.io.FileNotFoundException;
>> +import java.net.URI;
>> import java.net.URISyntaxException;
>> import java.net.URL;
>>
>> @@ -79,7 +80,7 @@
>> throw new FileNotFoundException( "Unable to find: " +
>> resource );
>> }
>>
>> - return new File( resourceUrl.toURI() );
>> + return new File( new URI( resourceUrl.getPath() ) );
>
> Shouldn't that be: new URI( resourceUrl.toString() ) to match the JDK5
> implementation?
>
>> }
>>
>> protected ArtifactRepository getLocalRepository()
>
> Cheers,
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---
John Casey
Committer and PMC Member, Apache Maven
mail: jdcasey at commonjava dot org
blog: http://www.ejlife.net/blogs/john