[jira] [Commented] (AMQ-6786) AbstractInactivityMonitor.startMonitorThreads() throws IllegalArgumentException

["Christopher L. Shannon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112865#comment-16112865 ] 

Christopher L. Shannon commented on AMQ-6786:
---------------------------------------------

I think the exception in this case is appropriate.  Setting a negative initialDelayTime is an error so an exception should be thrown indicating this so the value can be fixed.  With your patch the code will skip over scheduling of the tasks entirely which is probably not what a user wants.

> AbstractInactivityMonitor.startMonitorThreads() throws IllegalArgumentException
> -------------------------------------------------------------------------------
>
>                 Key: AMQ-6786
>                 URL: https://issues.apache.org/jira/browse/AMQ-6786
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: JMS client
>            Reporter: Giovanni Liva
>         Attachments: patchAMQ-6786.txt
>
>
> The method startMonitorThreads() of class org.apache.activemq.transport.AbstractInactivityMonitor can throw an IllegalArgumentException.
> The current code verifies that only _readCheckTime_ and _writeCheckTime_ are positive integers without checking the value of _initialDelayTime_ .



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)