You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/04/29 12:43:09 UTC

[GitHub] [sling-parent] stefanseifert opened a new pull request, #24: SLING-11291 make use of bnd:jar goal

stefanseifert opened a new pull request, #24:
URL: https://github.com/apache/sling-parent/pull/24

   move bnd plugin configuration out of executions section to apply it to both executions
   
   see also discussion inhttps://issues.apache.org/jira/browse/SLING-11291


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-parent] kwin commented on a diff in pull request #24: SLING-11291 make use of bnd:jar goal

Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #24:
URL: https://github.com/apache/sling-parent/pull/24#discussion_r862142570


##########
sling-bundle-parent/pom.xml:
##########
@@ -82,8 +77,20 @@ Bundle-DocURL: https://sling.apache.org
 -fixupmessages:"Export *,  has \\d+,  private references"; \
     restrict:=warning; \
     is:=error
-                                ]]></bnd>
-                            </configuration>
+                        ]]></bnd>
+                    </configuration>
+                    <executions>
+                        <execution>
+                            <id>bnd-process</id>
+                            <goals>
+                                <goal>bnd-process</goal>
+                            </goals>
+                        </execution>
+                        <execution>
+                            <id>bnd-jar</id>

Review Comment:
   bnd:jar encapsulates generating metadata and therefore OSGi metadata is generated twice in mvn package which seems quite some overhead



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-parent] kwin commented on a diff in pull request #24: SLING-11291 make use of bnd:jar goal

Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #24:
URL: https://github.com/apache/sling-parent/pull/24#discussion_r862142570


##########
sling-bundle-parent/pom.xml:
##########
@@ -82,8 +77,20 @@ Bundle-DocURL: https://sling.apache.org
 -fixupmessages:"Export *,  has \\d+,  private references"; \
     restrict:=warning; \
     is:=error
-                                ]]></bnd>
-                            </configuration>
+                        ]]></bnd>
+                    </configuration>
+                    <executions>
+                        <execution>
+                            <id>bnd-process</id>
+                            <goals>
+                                <goal>bnd-process</goal>
+                            </goals>
+                        </execution>
+                        <execution>
+                            <id>bnd-jar</id>

Review Comment:
   bnd:jar encapsulates generating metadata and therefore should metadata is generated twice in mvn package which seems quite some overhead



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-parent] stefanseifert commented on pull request #24: SLING-11291 make use of bnd:jar goal

Posted by GitBox <gi...@apache.org>.
stefanseifert commented on PR #24:
URL: https://github.com/apache/sling-parent/pull/24#issuecomment-1114630452

   abandoned as discussed in https://issues.apache.org/jira/browse/SLING-11291


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-parent] sonarcloud[bot] commented on pull request #24: SLING-11291 make use of bnd:jar goal

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #24:
URL: https://github.com/apache/sling-parent/pull/24#issuecomment-1113270209

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_sling-parent&pullRequest=24)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=24&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=24&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=24&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=24&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=24&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=24&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent&pullRequest=24&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent&pullRequest=24&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent&pullRequest=24&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=24&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=24&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=24&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_sling-parent&pullRequest=24) No Coverage information  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-parent&pullRequest=24&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-parent&pullRequest=24&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-parent] stefanseifert closed pull request #24: SLING-11291 make use of bnd:jar goal

Posted by GitBox <gi...@apache.org>.
stefanseifert closed pull request #24: SLING-11291 make use of bnd:jar goal 
URL: https://github.com/apache/sling-parent/pull/24


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org