You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/05 21:49:49 UTC
[GitHub] [spark] sarutak opened a new pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
sarutak opened a new pull request #29003:
URL: https://github.com/apache/spark/pull/29003
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR changes `webui.css` to fix a style issue on moving mouse cursor on the Spark logo.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
In the webui, the Spark logo is on the top right side.
When we move mouse cursor on the logo, a weird underline appears near the logo.
<img width="209" alt="logo_with_line" src="https://user-images.githubusercontent.com/4736016/86542828-3c6a9f00-bf54-11ea-9b9d-cc50c12c2c9b.png">
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. After this change applied, no more weird line shown even if mouse cursor moves on the logo.
<img width="207" alt="removed-line-from-logo" src="https://user-images.githubusercontent.com/4736016/86542877-98cdbe80-bf54-11ea-8695-ee39689673ab.png">
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
By moving mouse cursor on the Spark logo and confirmed no more weird line there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653946271
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653943608
**[Test build #124966 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124966/testReport)** for PR 29003 at commit [`c7cf8d7`](https://github.com/apache/spark/commit/c7cf8d7b580b1aa397b9777f1d3b30068e23120d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #29003:
URL: https://github.com/apache/spark/pull/29003
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653943608
**[Test build #124966 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124966/testReport)** for PR 29003 at commit [`c7cf8d7`](https://github.com/apache/spark/commit/c7cf8d7b580b1aa397b9777f1d3b30068e23120d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653977241
Thank you, @sarutak !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653950800
BTW, when I tried at Apache Spark 3.0.0 with Safari Private Window mode, I cannot reproduce the weird line. Is this `Chrome` only bug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653945737
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653943680
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653943776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-654048895
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653943680
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653950495
Hi, @sarutak . If you want to backport this to `branch-3.0`, could you set the JIRA type as `Bug` instead of `Improvement`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653943776
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-654048895
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653943772
**[Test build #124966 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124966/testReport)** for PR 29003 at commit [`c7cf8d7`](https://github.com/apache/spark/commit/c7cf8d7b580b1aa397b9777f1d3b30068e23120d).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653946271
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653943781
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124966/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653971480
It's strange but I've confirmed there are no weird line in `3.0.0` and `3.0.1-SNAPSHOT` (maybe, I've seen the line in the 3.0.0's history with 3.1.0's HistoryServer).
So I'll drop `3.0.0` from the Affect Version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653950800
BTW, when I tried at Apache Spark 3.0.0 with Safari Private Window mode, I cannot reproduce the weird line.
- Is this `Chrome` only bug?
- Does this occur only at the long version name with `-SNAPSHOT`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653956063
I verified this bug in 3.1.0-SNAPSHOT, but cannot reproduce at 3.0.1-SNAPSHOT with both Safari and Chrome.
Shall we drop `3.0.0` from the Affected Version in SPARK-32177?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653968007
I reproduced it in 3.0.0-SNAPSHOT as follows.
<img width="209" alt="weird-line-3 0 0" src="https://user-images.githubusercontent.com/4736016/86546638-eb1cd880-bf70-11ea-8789-2fd6fa09da0c.png">
It's for the SNAPSHOT so I'll confirm again for the released one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29003: [SPARK-32177][WEBUI] Remove the weird line from near the Spark logo on mouseover in the WebUI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29003:
URL: https://github.com/apache/spark/pull/29003#issuecomment-653946334
**[Test build #124968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124968/testReport)** for PR 29003 at commit [`c7cf8d7`](https://github.com/apache/spark/commit/c7cf8d7b580b1aa397b9777f1d3b30068e23120d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org