[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4434: Remove the massive console print and log from CalciteSqlCompilerTest

[GitBox <gi...@apache.org>]

mayankshriv commented on a change in pull request #4434: Remove the massive console print and log from CalciteSqlCompilerTest
URL: https://github.com/apache/incubator-pinot/pull/4434#discussion_r303606386
 
 

 ##########
 File path: pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java
 ##########
 @@ -339,60 +336,23 @@ public void testStringLiteral() {
     Assert.assertEquals(groupbyList.get(1).getFunctionCall().getOperands().get(1).getIdentifier().getName(), "FOO");
   }
 
-  @Test
-  public void testConverter()
 
 Review comment:
   While it makes sense to remove the logging, here's a prior conversation on the intention for this test.
   
   https://github.com/apache/incubator-pinot/pull/4387#discussion_r300516547

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org