You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/05/20 22:13:00 UTC

[jira] [Work logged] (GOBBLIN-1652) Add more log in the KafkaJobStatusMonitor in case it fails to process one GobblinTrackingEvent

     [ https://issues.apache.org/jira/browse/GOBBLIN-1652?focusedWorklogId=773034&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773034 ]

ASF GitHub Bot logged work on GOBBLIN-1652:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/May/22 22:12
            Start Date: 20/May/22 22:12
    Worklog Time Spent: 10m 
      Work Description: ZihanLi58 opened a new pull request, #3513:
URL: https://github.com/apache/gobblin/pull/3513

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1652
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if applicable):
   Now in some conner case, we fail to process one kafka message, and it's super hard to get the reason for why it fails. To get more info there we want to add more log when processing message. Along with this, we need to add null check in 
   
   modifyStateIfRetryRequired to avoid NPE as well.
   
   
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Add unit test
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 773034)
    Remaining Estimate: 0h
            Time Spent: 10m

> Add more log in the KafkaJobStatusMonitor in case it fails to process one GobblinTrackingEvent
> ----------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1652
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1652
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Zihan Li
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Now in some conner case, we fail to process one kafka message, and it's super hard to get the reason for why it fails. To get more info there we want to add more log when processing message. Along with this, we need to add null check inĀ 
> modifyStateIfRetryRequired to avoid NPE as well.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)