[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5442: feat: `extensions_options` macro

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #5442:
URL: https://github.com/apache/arrow-datafusion/pull/5442#discussion_r1123667727


##########
datafusion/core/tests/config.rs:
##########
@@ -0,0 +1,30 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use datafusion::common::extensions_options;
+
+// The structure is not really used. We just check that the macro re-export works and everything referenced within the

Review Comment:
   Can you please move this code to https://github.com/apache/arrow-datafusion/tree/main/datafusion-examples/examples
   
   That would also provide a good place maybe to provide some simple program showing how to use options created with this macro 
   
   
   
   Maybe we could add a small test showing that the configuration could be instantiated and used 🤔  As a way to try and document its use. 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org