You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/25 11:16:16 UTC
[GitHub] [spark] cloud-fan commented on issue #27665:
[SPARK-24355][Core][FOLLOWUP] Add flag for fetching chunks in async mode
cloud-fan commented on issue #27665: [SPARK-24355][Core][FOLLOWUP] Add flag for fetching chunks in async mode
URL: https://github.com/apache/spark/pull/27665#issuecomment-590816607
The default value of `spark.shuffle.server.chunkFetchHandlerThreadsPercent` is 100, so this feature is expected to be disabled by default IIUC.
Policy-wise, we should not fix an issue while introducing a regression. I'm OK to have it since it's disabled by default and it does fix a common issue. What I'm asking for is to make sure the code path is exactly the same as before when this feature is disabled, so that there is no regression.
+1 with @tgravescs to reuse the existing config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org