You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by jb...@apache.org on 2015/02/27 17:26:22 UTC

svn commit: r1662736 - in /tomcat/trunk/webapps/examples/WEB-INF/lib: jstl.jar standard.jar taglibs-standard-impl-1.2.3.jar taglibs-standard-spec-1.2.3.jar

Author: jboynes
Date: Fri Feb 27 16:26:21 2015
New Revision: 1662736

URL: http://svn.apache.org/r1662736
Log:
Replace old taglibs library with Apache Standard Taglib 1.2.3

Added:
    tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-impl-1.2.3.jar
    tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-spec-1.2.3.jar
Removed:
    tomcat/trunk/webapps/examples/WEB-INF/lib/jstl.jar
    tomcat/trunk/webapps/examples/WEB-INF/lib/standard.jar

Added: tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-impl-1.2.3.jar
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-impl-1.2.3.jar?rev=1662736&view=auto
==============================================================================
Binary files tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-impl-1.2.3.jar (added) and tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-impl-1.2.3.jar Fri Feb 27 16:26:21 2015 differ

Added: tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-spec-1.2.3.jar
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-spec-1.2.3.jar?rev=1662736&view=auto
==============================================================================
Binary files tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-spec-1.2.3.jar (added) and tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-spec-1.2.3.jar Fri Feb 27 16:26:21 2015 differ



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1662736 - in /tomcat/trunk/webapps/examples/WEB-INF/lib: jstl.jar standard.jar taglibs-standard-impl-1.2.3.jar taglibs-standard-spec-1.2.3.jar

Posted by Konstantin Kolinko <kn...@gmail.com>.
2015-02-28 6:57 GMT+03:00 Jeremy Boynes <jb...@apache.org>:
> On Feb 27, 2015, at 6:43 PM, Jeremy Boynes <jb...@apache.org> wrote:
>>
>> On Feb 27, 2015, at 11:19 AM, Konstantin Kolinko <kn...@gmail.com> wrote:
>>>
>>> 2015-02-27 19:26 GMT+03:00  <jb...@apache.org>:
>>>> Author: jboynes
>>>> Date: Fri Feb 27 16:26:21 2015
>>>> New Revision: 1662736
>>>>
>>>> URL: http://svn.apache.org/r1662736
>>>> Log:
>>>> Replace old taglibs library with Apache Standard Taglib 1.2.3
>>>>
>>>> Added:
>>>>   tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-impl-1.2.3.jar
>>>>   tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-spec-1.2.3.jar
>>>> Removed:
>>>>   tomcat/trunk/webapps/examples/WEB-INF/lib/jstl.jar
>>>>   tomcat/trunk/webapps/examples/WEB-INF/lib/standard.jar
>>>>
>>>
>>>
>>> I guess that taglibs-standard-impl-*.jar has to be added to
>>> "tomcat.util.scan.StandardJarScanFilter.jarsToSkip" setting
>>> in conf/catalina.properties  to exclude it during TLD scanning, as the
>>> jar contains no TLDs.
>>>
>>> That setting already has "jstl.jar" but not the new file name.
>>>
>>> (The examples app should log a warning when it compiles the first JSP).
>>
>> This confused me this morning and I was going to look in to it tonight. I did not see that warning when running on trunk or tc8 but did on tc7. I expected to. Thanks for updating those two branches; I’ll figure out what was going on assuming it’s not just that I was under-caffinated.
>
> Nope, the caffine level was adequate. The message is now only emitted if no jars contain a TLD whereas it should if at least one does not.
>
> Opened https://bz.apache.org/bugzilla/show_bug.cgi?id=57647
> I’ll try to get to it this weekend.


There have been the following fixes by Remy:
http://svn.apache.org/r1662850
http://svn.apache.org/r1662843

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1662736 - in /tomcat/trunk/webapps/examples/WEB-INF/lib: jstl.jar standard.jar taglibs-standard-impl-1.2.3.jar taglibs-standard-spec-1.2.3.jar

Posted by Jeremy Boynes <jb...@apache.org>.
On Feb 27, 2015, at 6:43 PM, Jeremy Boynes <jb...@apache.org> wrote:
> 
> On Feb 27, 2015, at 11:19 AM, Konstantin Kolinko <kn...@gmail.com> wrote:
>> 
>> 2015-02-27 19:26 GMT+03:00  <jb...@apache.org>:
>>> Author: jboynes
>>> Date: Fri Feb 27 16:26:21 2015
>>> New Revision: 1662736
>>> 
>>> URL: http://svn.apache.org/r1662736
>>> Log:
>>> Replace old taglibs library with Apache Standard Taglib 1.2.3
>>> 
>>> Added:
>>>   tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-impl-1.2.3.jar
>>>   tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-spec-1.2.3.jar
>>> Removed:
>>>   tomcat/trunk/webapps/examples/WEB-INF/lib/jstl.jar
>>>   tomcat/trunk/webapps/examples/WEB-INF/lib/standard.jar
>>> 
>> 
>> 
>> I guess that taglibs-standard-impl-*.jar has to be added to
>> "tomcat.util.scan.StandardJarScanFilter.jarsToSkip" setting
>> in conf/catalina.properties  to exclude it during TLD scanning, as the
>> jar contains no TLDs.
>> 
>> That setting already has "jstl.jar" but not the new file name.
>> 
>> (The examples app should log a warning when it compiles the first JSP).
> 
> This confused me this morning and I was going to look in to it tonight. I did not see that warning when running on trunk or tc8 but did on tc7. I expected to. Thanks for updating those two branches; I’ll figure out what was going on assuming it’s not just that I was under-caffinated.

Nope, the caffine level was adequate. The message is now only emitted if no jars contain a TLD whereas it should if at least one does not.

Opened https://bz.apache.org/bugzilla/show_bug.cgi?id=5764
I’ll try to get to it this weekend.

Cheers
Jeremy


Re: svn commit: r1662736 - in /tomcat/trunk/webapps/examples/WEB-INF/lib: jstl.jar standard.jar taglibs-standard-impl-1.2.3.jar taglibs-standard-spec-1.2.3.jar

Posted by Jeremy Boynes <jb...@apache.org>.
On Feb 27, 2015, at 11:19 AM, Konstantin Kolinko <kn...@gmail.com> wrote:
> 
> 2015-02-27 19:26 GMT+03:00  <jb...@apache.org>:
>> Author: jboynes
>> Date: Fri Feb 27 16:26:21 2015
>> New Revision: 1662736
>> 
>> URL: http://svn.apache.org/r1662736
>> Log:
>> Replace old taglibs library with Apache Standard Taglib 1.2.3
>> 
>> Added:
>>    tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-impl-1.2.3.jar
>>    tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-spec-1.2.3.jar
>> Removed:
>>    tomcat/trunk/webapps/examples/WEB-INF/lib/jstl.jar
>>    tomcat/trunk/webapps/examples/WEB-INF/lib/standard.jar
>> 
> 
> 
> I guess that taglibs-standard-impl-*.jar has to be added to
> "tomcat.util.scan.StandardJarScanFilter.jarsToSkip" setting
> in conf/catalina.properties  to exclude it during TLD scanning, as the
> jar contains no TLDs.
> 
> That setting already has "jstl.jar" but not the new file name.
> 
> (The examples app should log a warning when it compiles the first JSP).

This confused me this morning and I was going to look in to it tonight. I did not see that warning when running on trunk or tc8 but did on tc7. I expected to. Thanks for updating those two branches; I’ll figure out what was going on assuming it’s not just that I was under-caffinated.

Thanks
Jeremy


Re: svn commit: r1662736 - in /tomcat/trunk/webapps/examples/WEB-INF/lib: jstl.jar standard.jar taglibs-standard-impl-1.2.3.jar taglibs-standard-spec-1.2.3.jar

Posted by Konstantin Kolinko <kn...@gmail.com>.
2015-02-27 19:26 GMT+03:00  <jb...@apache.org>:
> Author: jboynes
> Date: Fri Feb 27 16:26:21 2015
> New Revision: 1662736
>
> URL: http://svn.apache.org/r1662736
> Log:
> Replace old taglibs library with Apache Standard Taglib 1.2.3
>
> Added:
>     tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-impl-1.2.3.jar
>     tomcat/trunk/webapps/examples/WEB-INF/lib/taglibs-standard-spec-1.2.3.jar
> Removed:
>     tomcat/trunk/webapps/examples/WEB-INF/lib/jstl.jar
>     tomcat/trunk/webapps/examples/WEB-INF/lib/standard.jar
>


I guess that taglibs-standard-impl-*.jar has to be added to
"tomcat.util.scan.StandardJarScanFilter.jarsToSkip" setting
in conf/catalina.properties  to exclude it during TLD scanning, as the
jar contains no TLDs.

That setting already has "jstl.jar" but not the new file name.

(The examples app should log a warning when it compiles the first JSP).

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org