You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jackrabbit.apache.org by an...@apache.org on 2008/09/26 18:11:37 UTC

svn commit: r699392 - /jackrabbit/trunk/jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/hierarchy/NodeEntryImpl.java

Author: angela
Date: Fri Sep 26 09:11:37 2008
New Revision: 699392

URL: http://svn.apache.org/viewvc?rev=699392&view=rev
Log:
JCR-1771 Avoid unnecessary roundtrips with NodeEntry.getPropertyEntry

Modified:
    jackrabbit/trunk/jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/hierarchy/NodeEntryImpl.java

Modified: jackrabbit/trunk/jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/hierarchy/NodeEntryImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/hierarchy/NodeEntryImpl.java?rev=699392&r1=699391&r2=699392&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/hierarchy/NodeEntryImpl.java (original)
+++ jackrabbit/trunk/jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/hierarchy/NodeEntryImpl.java Fri Sep 26 09:11:37 2008
@@ -662,18 +662,13 @@
     }
 
     /**
-     * @inheritDoc
+     * Ignores the <code>loadIfNotFound</code> flag due to the fact, that
+     * {@link org.apache.jackrabbit.spi.NodeInfo#getPropertyIds()} returns the
+     * complete list of property names currently available.
      * @see NodeEntry#getPropertyEntry(Name, boolean)
      */
     public PropertyEntry getPropertyEntry(Name propName, boolean loadIfNotFound) throws RepositoryException {
-        PropertyEntry entry = properties.get(propName);
-        if (entry == null && loadIfNotFound && Status.NEW != getStatus()) {
-            PropertyId propId = factory.getIdFactory().createPropertyId(getId(), propName);
-            entry = loadPropertyEntry(propId);
-        } else if (!EntryValidation.isValidPropertyEntry(entry)) {
-            entry = null;
-        }
-        return entry;
+        return getPropertyEntry(propName);
     }
 
     /**