You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/05/02 20:07:35 UTC
Re: Review Request 58489: VersionAdvertised should be set to False by
default in stack_tool.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58489/#review173637
-----------------------------------------------------------
What's the state of this review? Seems like it's been dormant for a week...
- Jonathan Hurley
On April 19, 2017, 3:29 a.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58489/
> -----------------------------------------------------------
>
> (Updated April 19, 2017, 3:29 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20775
> https://issues.apache.org/jira/browse/AMBARI-20775
>
>
> Repository: ambari
>
>
> Description
> -------
>
> All the commands.json files should always contain the versionAdvertised field. If versionAdvertised is not set in command.json then we should assume that versionAdvertised=False when calling stack_tools.py
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py 463d61f53d
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 93ec0b74f5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 2c441ad5a0
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 3579fcbd2a
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py ab5e2cdaf9
> ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json 0b5ba6a0ba
> ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0a30
> ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 6ec9ec929c
> ambari-server/src/test/python/stacks/2.0.6/configs/flume_only.json 1550715d72
> ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 013bb8b8d2
> ambari-server/src/test/python/stacks/2.1/configs/default.json e04e1eb9f4
> ambari-server/src/test/python/stacks/2.2/configs/default.json bcb021b74f
> ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json 7ded3a01e1
> ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json 7a29ea0c0d
> ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json a9db11c645
> ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json fb561f74f3
> ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 86ca03a4a3
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json cbe8ebeb15
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json dc4c43b9e0
> ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json 0da58ce2a5
>
>
> Diff: https://reviews.apache.org/r/58489/diff/3/
>
>
> Testing
> -------
>
> Tested for service actions:
> Start
> Stop
> Restart
> Reconfigure
> Service Check
> Enable HA
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58489: VersionAdvertised should be set to False by
default in stack_tool.py
Posted by Nate Cole <nc...@hortonworks.com>.
> On May 2, 2017, 4:07 p.m., Jonathan Hurley wrote:
> > What's the state of this review? Seems like it's been dormant for a week...
>
> Madhuvanthi Radhakrishnan wrote:
> Hi Jonathan,
> This patch was scraped for 2.5.1 since the changes were made in the HDF mpack instead. But we do want to keep this approach open for discussion for 3.0.0
In that case, please close the review. Discussion won't happen on a code review.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58489/#review173637
-----------------------------------------------------------
On April 19, 2017, 3:29 a.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58489/
> -----------------------------------------------------------
>
> (Updated April 19, 2017, 3:29 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20775
> https://issues.apache.org/jira/browse/AMBARI-20775
>
>
> Repository: ambari
>
>
> Description
> -------
>
> All the commands.json files should always contain the versionAdvertised field. If versionAdvertised is not set in command.json then we should assume that versionAdvertised=False when calling stack_tools.py
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py 463d61f53d
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 93ec0b74f5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 2c441ad5a0
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 3579fcbd2a
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py ab5e2cdaf9
> ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json 0b5ba6a0ba
> ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0a30
> ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 6ec9ec929c
> ambari-server/src/test/python/stacks/2.0.6/configs/flume_only.json 1550715d72
> ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 013bb8b8d2
> ambari-server/src/test/python/stacks/2.1/configs/default.json e04e1eb9f4
> ambari-server/src/test/python/stacks/2.2/configs/default.json bcb021b74f
> ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json 7ded3a01e1
> ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json 7a29ea0c0d
> ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json a9db11c645
> ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json fb561f74f3
> ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 86ca03a4a3
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json cbe8ebeb15
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json dc4c43b9e0
> ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json 0da58ce2a5
>
>
> Diff: https://reviews.apache.org/r/58489/diff/3/
>
>
> Testing
> -------
>
> Tested for service actions:
> Start
> Stop
> Restart
> Reconfigure
> Service Check
> Enable HA
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58489: VersionAdvertised should be set to False by
default in stack_tool.py
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
> On May 2, 2017, 8:07 p.m., Jonathan Hurley wrote:
> > What's the state of this review? Seems like it's been dormant for a week...
Hi Jonathan,
This patch was scraped for 2.5.1 since the changes were made in the HDF mpack instead. But we do want to keep this approach open for discussion for 3.0.0
- Madhuvanthi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58489/#review173637
-----------------------------------------------------------
On April 19, 2017, 7:29 a.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58489/
> -----------------------------------------------------------
>
> (Updated April 19, 2017, 7:29 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20775
> https://issues.apache.org/jira/browse/AMBARI-20775
>
>
> Repository: ambari
>
>
> Description
> -------
>
> All the commands.json files should always contain the versionAdvertised field. If versionAdvertised is not set in command.json then we should assume that versionAdvertised=False when calling stack_tools.py
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py 463d61f53d
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 93ec0b74f5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 2c441ad5a0
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 3579fcbd2a
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py ab5e2cdaf9
> ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json 0b5ba6a0ba
> ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0a30
> ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 6ec9ec929c
> ambari-server/src/test/python/stacks/2.0.6/configs/flume_only.json 1550715d72
> ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 013bb8b8d2
> ambari-server/src/test/python/stacks/2.1/configs/default.json e04e1eb9f4
> ambari-server/src/test/python/stacks/2.2/configs/default.json bcb021b74f
> ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json 7ded3a01e1
> ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json 7a29ea0c0d
> ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json a9db11c645
> ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json fb561f74f3
> ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 86ca03a4a3
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json cbe8ebeb15
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json dc4c43b9e0
> ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json 0da58ce2a5
>
>
> Diff: https://reviews.apache.org/r/58489/diff/3/
>
>
> Testing
> -------
>
> Tested for service actions:
> Start
> Stop
> Restart
> Reconfigure
> Service Check
> Enable HA
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>