You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/25 09:56:53 UTC

[GitHub] [shardingsphere] yang-7777 opened a new pull request #7607: Update vote.en.md

yang-7777 opened a new pull request #7607:
URL: https://github.com/apache/shardingsphere/pull/7607


   change the title
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yang-7777 closed pull request #7607: Update vote.en.md

Posted by GitBox <gi...@apache.org>.
yang-7777 closed pull request #7607:
URL: https://github.com/apache/shardingsphere/pull/7607


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #7607: Update vote.en.md

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #7607:
URL: https://github.com/apache/shardingsphere/pull/7607#discussion_r494892855



##########
File path: docs/community/content/contribute/vote.en.md
##########
@@ -1,10 +1,10 @@
 +++ 
-title = "Accept a new committer process" 
+title = " New committer voting process" 
 weight = 12
 chapter = true 
 +++
 
-## Processes on accepting a new committer are:
+## Voting process of become a new committer

Review comment:
       Becoming?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yang-7777 closed pull request #7607: Update vote.en.md

Posted by GitBox <gi...@apache.org>.
yang-7777 closed pull request #7607:
URL: https://github.com/apache/shardingsphere/pull/7607


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls commented on pull request #7607: Update vote.en.md

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7607:
URL: https://github.com/apache/shardingsphere/pull/7607#issuecomment-698873633


   ## Pull Request Test Coverage Report for [Build 15073](https://coveralls.io/builds/33719775)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **1** unchanged line in **1** file lost coverage.
   * Overall coverage increased (+**0.006%**) to **35.117%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-infra/shardingsphere-infra-route/src/main/java/org/apache/shardingsphere/infra/route/context/RouteContext.java](https://coveralls.io/builds/33719775/source?filename=shardingsphere-infra%2Fshardingsphere-infra-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Froute%2Fcontext%2FRouteContext.java#L82) | 1 | 94.44% |
   <!-- | **Total:** | **1** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/33719775/badge)](https://coveralls.io/builds/33719775) |
   | :-- | --: |
   | Change from base [Build 15072](https://coveralls.io/builds/33719234): |  0.006% |
   | Covered Lines: | 36632 |
   | Relevant Lines: | 104314 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #7607: Update vote.en.md

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #7607:
URL: https://github.com/apache/shardingsphere/pull/7607#discussion_r494892855



##########
File path: docs/community/content/contribute/vote.en.md
##########
@@ -1,10 +1,10 @@
 +++ 
-title = "Accept a new committer process" 
+title = " New committer voting process" 
 weight = 12
 chapter = true 
 +++
 
-## Processes on accepting a new committer are:
+## Voting process of become a new committer

Review comment:
       Becoming?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls commented on pull request #7607: Update vote.en.md

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7607:
URL: https://github.com/apache/shardingsphere/pull/7607#issuecomment-698873633


   ## Pull Request Test Coverage Report for [Build 15073](https://coveralls.io/builds/33719775)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **1** unchanged line in **1** file lost coverage.
   * Overall coverage increased (+**0.006%**) to **35.117%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-infra/shardingsphere-infra-route/src/main/java/org/apache/shardingsphere/infra/route/context/RouteContext.java](https://coveralls.io/builds/33719775/source?filename=shardingsphere-infra%2Fshardingsphere-infra-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Froute%2Fcontext%2FRouteContext.java#L82) | 1 | 94.44% |
   <!-- | **Total:** | **1** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/33719775/badge)](https://coveralls.io/builds/33719775) |
   | :-- | --: |
   | Change from base [Build 15072](https://coveralls.io/builds/33719234): |  0.006% |
   | Covered Lines: | 36632 |
   | Relevant Lines: | 104314 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org