You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2017/04/11 17:59:31 UTC
[GitHub] storm pull request #2060: STORM-2468: Remove clojure from storm-client
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2060
STORM-2468: Remove clojure from storm-client
This is based off STORM-2447
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2468
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2060.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2060
----
commit b254ede46a25466749cd48ebd4bcb56dd791ec4a
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2017-04-06T18:58:41Z
STORM-2447: add in storm local to avoid having server on worker classpath
commit 9eced5310464f87ca52eb92b6224ef5abe531514
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2017-04-06T19:50:14Z
STORM-2447: Fixed compilation issue with int test
commit 71dc2e019d84580fbcdd5eabf267016393324872
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2017-04-07T13:31:56Z
Merge branch 'apache-master' into STORM-2447
commit 979d0b89f1b76342a25091dd381d3faeefa71ad0
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2017-04-10T12:51:02Z
STORM-2468: Remove clojure from storm-client
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2060: STORM-2468: Remove clojure from storm-client
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2060
+1 Sorry for the delayed review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2060: STORM-2468: Remove clojure from storm-client
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2060
@knusbaum please take a look at this.
There were a number of changes here. Some to replace functionality being used from clojure runtime with java code. Some of it was moving/deduplicating dependencies, but the two big ones were adding in support to register the clojure kryo serialization transparently and making a tuple have the same clojure integration it had before by replacing it with a new tuple.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2060: STORM-2468: Remove clojure from storm-client
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2060
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2060: STORM-2468: Remove clojure from storm-client
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2060
Only the last commit is the one to look at.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2060: STORM-2468: Remove clojure from storm-client
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2060
Missed the previous request. This all looks good to me.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2060: STORM-2468: Remove clojure from storm-client
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2060
@HeartSaVioR @ptgoetz If you have time to take a look I would appreciate it. It looks like @knusbaum might be a bit too busy to take a look in a timely manor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2060: STORM-2468: Remove clojure from storm-client
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2060
Now that STORM-2447 is in I have rebased this on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---