You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by shakir774 <gi...@git.apache.org> on 2015/06/10 23:02:31 UTC
[GitHub] flink pull request: FLINK-1732 Gaussian Mixture Model for Flink-ml...
GitHub user shakir774 opened a pull request:
https://github.com/apache/flink/pull/823
FLINK-1732 Gaussian Mixture Model for Flink-ml library
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shakir774/flink gmm_feature
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/823.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #823
----
commit 3d12b27efa2dc623ce05e8eea05cdf0aeea4b330
Author: shakir774 <sh...@gmail.com>
Date: 2015-06-05T16:32:51Z
Gaussian Mixture Model for flink ml library FLINK-1732
commit a03a987b79fa3e3ca8e009553980bc2b62b0b8f6
Author: shakir.waseeb <sh...@campus.tu-berlin.de>
Date: 2015-06-10T20:53:04Z
Tests for GMM feature
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-1732 Gaussian Mixture Model for Flink-ml...
Posted by shakir774 <gi...@git.apache.org>.
Github user shakir774 commented on the pull request:
https://github.com/apache/flink/pull/823#issuecomment-111136272
Given following error while executing the test suite by Travis CI.
Even `import org.apache.flink.ml.common._` is imported, what may cause this error.
```
[INFO] ^
[ERROR] /home/travis/build/apache/flink/flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/clustering/GMM.scala:95: error: not found: type Learner
[INFO] class GMM extends Learner[Point,GMModel] {
[INFO] ^
[ERROR] /home/travis/build/apache/flink/flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/clustering/GMM.scala:105: error: not found: value parameters
[INFO] parameters.add(NumIterations, numIterations)
[INFO] ^
[ERROR] /home/travis/build/apache/flink/flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/clustering/GMM.scala:115: error: not found: value parameters
[INFO] parameters.add(NumGaussians, numGaussians)
[INFO] ^
[ERROR] /home/travis/build/apache/flink/flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/clustering/GMM.scala:125: error: not found: value parameters
[INFO] parameters.add(InitialGaussians,initialGaussians)
[INFO] ^
[ERROR] /home/travis/build/apache/flink/flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/clustering/GMM.scala:258: error: not found: type Transformer
[INFO] case class GMModel(gmm: DataSet[Gaussian]) extends Transformer[Point, Prediction]
[INFO] ^
[ERROR] /home/travis/build/apache/flink/flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/clustering/GMM.scala:137: error: value parameters is not a member of org.apache.flink.ml.clustering.GMM
[INFO] val resultingParameters = this.parameters ++ fitParameters
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-1732 Gaussian Mixture Model for Flink-ml...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/823#issuecomment-111345151
You should port your implementation to the new Pipeline mechanism. Check out the master. It's been around for almost one month now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-1732 Gaussian Mixture Model for Flink-ml...
Posted by shakir774 <gi...@git.apache.org>.
Github user shakir774 commented on the pull request:
https://github.com/apache/flink/pull/823#issuecomment-114666761
@thvasilo as we are busy with our next task of IMPRO-3.SS15 for the semester, once we finished with it, I will rebase it according to the new pipeline mechanism.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-1732 Gaussian Mixture Model for Flink-ml...
Posted by thvasilo <gi...@git.apache.org>.
Github user thvasilo commented on the pull request:
https://github.com/apache/flink/pull/823#issuecomment-114134005
Hello @shakir774 , as @sachingoel0101 mentioned you must rebase your current implementation on the current master as the underlying code for FlinkML has changed considerably. We can review this PR once you have done that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---