You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "villebro (via GitHub)" <gi...@apache.org> on 2023/02/01 16:39:10 UTC

[GitHub] [superset] villebro commented on a diff in pull request #22942: fix: add new config to allow for specific import data urls

villebro commented on code in PR #22942:
URL: https://github.com/apache/superset/pull/22942#discussion_r1093467623


##########
superset/datasets/commands/exceptions.py:
##########
@@ -191,3 +191,7 @@ class DatasetAccessDeniedError(ForbiddenError):
 
 class DatasetDuplicateFailedError(CreateFailedError):
     message = _("Dataset could not be duplicated.")
+
+
+class DatasetUnAllowedDataURI(ForbiddenError):

Review Comment:
   nit: how do you feel about `DatasetDisallowedDataURI` or `DatasetForbiddenDataURI`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org