You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by brodybits <gi...@git.apache.org> on 2015/04/17 00:13:51 UTC
[GitHub] cordova-windows pull request: CB-8866: add Windows platforms "Mixe...
GitHub user brodybits opened a pull request:
https://github.com/apache/cordova-windows/pull/67
CB-8866: add Windows platforms "Mixed Platforms" and "Win32"
See [CB-8866](https://issues.apache.org/jira/browse/CB-8866): This is needed to install a plugin with a C++ component library such as: https://github.com/litehelpers/Cordova-sqlite-storage
If I would use the Cordova CLI to install the sqlite plugin, I can only build for certain CPU targets. This seems to be contrary to the "Windows Universal" approach.
Note my ICLA for Apache was already accepted for apache/cordova-wp8#72.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brodybits/cordova-windows CB-8866
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/67.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #67
----
commit e857332aaf1c29525464c7bbe758a9e370dcf18a
Author: Chris Brody <br...@litehelpers.net>
Date: 2015-04-16T22:02:02Z
CB-8866: add Windows platforms "Mixed Platforms" and "Win32"
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8866: add Windows platforms "Mixe...
Posted by brodybits <gi...@git.apache.org>.
Github user brodybits commented on the pull request:
https://github.com/apache/cordova-windows/pull/67#issuecomment-96677896
When can this fix be considered? People are having problems using the sqlite plugin with the Visual Studio Cordova project template (ref: litehelpers/Cordova-sqlite-storage#237)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8866: add Windows platforms "Mixe...
Posted by robpaveza <gi...@git.apache.org>.
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/67#issuecomment-123830935
@brodybits: Have you been unblocked by using the `--archs` parameter?
In my experience, building Windows apps using a "Mixed Platforms" solution platform is almost always undesirable. Do you think we could close this PR out?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8866: add Windows platforms "Mixe...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/67#issuecomment-96740713
You cannot build for win32 with windows-universal.
Universal in this case means wp8.1 and windows8.1 apps distributed by the windows app store.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8866: add Windows platforms "Mixe...
Posted by brodybits <gi...@git.apache.org>.
Github user brodybits closed the pull request at:
https://github.com/apache/cordova-windows/pull/67
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8866: add Windows platforms "Mixe...
Posted by brodybits <gi...@git.apache.org>.
Github user brodybits commented on the pull request:
https://github.com/apache/cordova-windows/pull/67#issuecomment-97033277
> I believe cordova windows provides an --archs option to specify the
> architectures to build. Is that not sufficient for your purposes? Here's the
> exact syntax:
> cordova build windows -- --archs="x86"
OK-then we need to select the architecture (`x86`|`x86-64`|`arm`) if we use Visual Studio as well.
Another thing is that people are having trouble using my plugin with a Visual Studio Cordova project, as reported in litehelpers/Cordova-sqlite-storage#237. Our workaround was to use `plugman`. I hope we can find a better solution for this.
These problems show up due to including a C++ project, which seems perfectly valid but not done for most Windows "Universal" plugins. I expect someone using https://github.com/AllJoyn-Cordova/cordova-plugin-alljoyn will encounter similar issues.
I am taking holiday this week, planning to try again to find a solution for the problem using the Visual Studio Cordova template when I come back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8866: add Windows platforms "Mixe...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/67#issuecomment-96893624
I believe cordova windows provides an --archs option to specify the architectures to build. Is that not sufficient for your purposes? Here's the exact syntax:
`cordova build windows -- --archs="x86"`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8866: add Windows platforms "Mixe...
Posted by brodybits <gi...@git.apache.org>.
Github user brodybits commented on the pull request:
https://github.com/apache/cordova-windows/pull/67#issuecomment-123846880
> Have you been unblocked by using the --archs parameter?
Yes. I think this should be documented very clearly (I will document this in my own plugin when I get a chance).
> In my experience, building Windows apps using a "Mixed Platforms" solution platform is almost always undesirable. Do you think we could close this PR out?
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8866: add Windows platforms "Mixe...
Posted by brodybits <gi...@git.apache.org>.
Github user brodybits commented on the pull request:
https://github.com/apache/cordova-windows/pull/67#issuecomment-96760704
I just pushed a new change to add "Mixed Platforms" *only*, based off the latest commit in the `master` branch. For reference purpose only, my first proposed fix is preserved in my `CB-8866-all` branch.
Please let me know if it is OK or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org