You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@tsfile.apache.org by "HTHou (via GitHub)" <gi...@apache.org> on 2024/11/04 10:12:13 UTC
[PR] Fix 1.1.0 rc1 issues [tsfile]
HTHou opened a new pull request, #283:
URL: https://github.com/apache/tsfile/pull/283
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix 1.1.0 rc1 issues [tsfile]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on PR #283:
URL: https://github.com/apache/tsfile/pull/283#issuecomment-2456625420
> However ... seeing that the files in there are greatly different from the ones in the original repo ... one might argue that it's ok to leave our own headers in there.
ok, so we are good now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix 1.1.0 rc1 issues [tsfile]
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #283:
URL: https://github.com/apache/tsfile/pull/283#issuecomment-2457035313
I think so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix 1.1.0 rc1 issues [tsfile]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #283:
URL: https://github.com/apache/tsfile/pull/283#issuecomment-2454808028
## [Codecov](https://app.codecov.io/gh/apache/tsfile/pull/283?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 62.39%. Comparing base [(`483819a`)](https://app.codecov.io/gh/apache/tsfile/commit/483819a6c62937704bc999c1db488309f1033171?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`088ae1b`)](https://app.codecov.io/gh/apache/tsfile/commit/088ae1b48b07f17d2cc737bd7d961942e25e5176?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## rc/1.1 #283 +/- ##
=======================================
Coverage 62.39% 62.39%
=======================================
Files 419 419
Lines 27602 27602
Branches 3598 3598
=======================================
Hits 17222 17222
Misses 10041 10041
Partials 339 339
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tsfile/pull/283?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix 1.1.0 rc1 issues [tsfile]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #283:
URL: https://github.com/apache/tsfile/pull/283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix 1.1.0 rc1 issues [tsfile]
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on code in PR #283:
URL: https://github.com/apache/tsfile/pull/283#discussion_r1827509918
##########
pom.xml:
##########
@@ -109,6 +109,7 @@
<exclude>**/.png</exclude>
<exclude>**/.jpg</exclude>
<exclude>**/.jpeg</exclude>
+ <exclude>**/.svg</exclude>
Review Comment:
SVGs are technically sourcecode and if the images are created by us, we should simply add the apache header to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix 1.1.0 rc1 issues [tsfile]
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #283:
URL: https://github.com/apache/tsfile/pull/283#issuecomment-2456510627
The Gorilla and Chimp files ... do we have a software-grant for them? If not we should have the original file-header on them.
It seems that the author used no header, then we should probably change the headers in these files to this one:
```
Copyright [yyyy] [name of copyright owner]
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix 1.1.0 rc1 issues [tsfile]
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #283:
URL: https://github.com/apache/tsfile/pull/283#issuecomment-2456522339
However ... seeing that the files in there are greatly different from the ones in the original repo ... one might argue that it's ok to leave our own headers in there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix 1.1.0 rc1 issues [tsfile]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on PR #283:
URL: https://github.com/apache/tsfile/pull/283#issuecomment-2456599581
> The Gorilla and Chimp files ... do we have a software-grant for them?
For Chimp, absolute yes. The Chimp code in TsFile was actually contributed by the author of Chimp. See https://github.com/apache/iotdb/pull/8766 and https://www.linkedin.com/posts/apache-iotdb_apacheiotdb-activity-7026131776376860672-eVFI?utm_source=share&utm_medium=member_desktop
As for gorilla, I don't think so. So, we need to change some headers, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix 1.1.0 rc1 issues [tsfile]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on code in PR #283:
URL: https://github.com/apache/tsfile/pull/283#discussion_r1827512320
##########
pom.xml:
##########
@@ -109,6 +109,7 @@
<exclude>**/.png</exclude>
<exclude>**/.jpg</exclude>
<exclude>**/.jpeg</exclude>
+ <exclude>**/.svg</exclude>
Review Comment:
OK, let me change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org