You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Stamatis Zampetakis (JIRA)" <ji...@apache.org> on 2019/07/19 13:17:00 UTC

[jira] [Updated] (CALCITE-2589) VolcanoPlanner#fireRules and VolcanoRuleCall#matchRecurse should ignore known-to-be-unimportant relations

     [ https://issues.apache.org/jira/browse/CALCITE-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stamatis Zampetakis updated CALCITE-2589:
-----------------------------------------
    Fix Version/s: 1.21.0

> VolcanoPlanner#fireRules and VolcanoRuleCall#matchRecurse should ignore known-to-be-unimportant relations
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-2589
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2589
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: Vladimir Sitnikov
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.21.0
>
>
> {{call.getPlanner().setImportance}} is used to avoid use of known-to-be-inefficient relation, however the check of importance is performed very late.
> The check is performed in org.apache.calcite.plan.volcano.RuleQueue#skipMatch when ruleCalls have already been created.
> I suggest to move the check into VolcanoPlanner#fireRules and VolcanoRuleCall#matchRecurse
> It would reduce amount of "possible" rule executions.
> Note: calling setImportance BEFORE transformTo would would help as well to filter out unimportant rule calls early.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)