You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/02/07 18:40:25 UTC
[GitHub] [fineract] galovics opened a new pull request #2029: FINERACT-1497: Fixing Swagger Code generation on Windows
galovics opened a new pull request #2029:
URL: https://github.com/apache/fineract/pull/2029
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #2029: FINERACT-1497: Fixing Swagger Code generation on Windows
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #2029:
URL: https://github.com/apache/fineract/pull/2029#issuecomment-1032020981
Now looking into this, I thought this was changed because without this, the incremental build did not work correctly. But looks like the incremental build is now broken for fineract-client anyway and a full rebuild is always triggered. What's even worse looks like the rebuild now fails in :fineract-client:licenseGenerated when the first build has worked. So something is quite broken with the fineract-client build. Need to investigate when it was broken - at the very least, clean / build or just build should work, and ideally even work as an incremental build running only the steps that are required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #2029: FINERACT-1497: Fixing Swagger Code generation on Windows
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #2029:
URL: https://github.com/apache/fineract/pull/2029#issuecomment-1032005616
Btw @vidakovic any idea why the integration tests are now super-fast? All of them completed in 10 minutes in this build - they used to take around 1 hour... whatever you've changed has really made a huge difference! :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #2029: FINERACT-1497: Fixing Swagger Code generation on Windows
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #2029:
URL: https://github.com/apache/fineract/pull/2029#issuecomment-1032003345
I recall that file:// was added because otherwise the generator tried to use classloader to load the file, and this did not work in some scenarios. But let's try - maybe there have been other changes that mean this now works...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2029: FINERACT-1497: Fixing Swagger Code generation on Windows
Posted by GitBox <gi...@apache.org>.
galovics commented on pull request #2029:
URL: https://github.com/apache/fineract/pull/2029#issuecomment-1031796704
Note that this is aimed to be included in 1.7. Not necessary for 1.6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola merged pull request #2029: FINERACT-1497: Fixing Swagger Code generation on Windows
Posted by GitBox <gi...@apache.org>.
ptuomola merged pull request #2029:
URL: https://github.com/apache/fineract/pull/2029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2029: FINERACT-1497: Fixing Swagger Code generation on Windows
Posted by GitBox <gi...@apache.org>.
galovics commented on pull request #2029:
URL: https://github.com/apache/fineract/pull/2029#issuecomment-1032397557
@ptuomola Thanks for taking the time and giving feedback. I appreciate.
Your point is probably valid and in some corner cases this doesn't work and I'm not sure if this is going to work in all environments.
The reason why on Windows this didn't work is because the file URI schema is not followed.
The `file://` prefix is missing an extra slash since it's pointing to a local file. According to the RFC, this is not a valid URI scheme for files but some systems accept it. [RFC here](https://datatracker.ietf.org/doc/html/rfc8089#appendix-B)
To make sure this still works the way it should, instead of removing the file URI prefix, I added the extra missing slash to make sure it's compliant with the RFC and that's something Windows also accepts. The end result is `file:///`
See the updated PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org