You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Alex Sorokoumov (Jira)" <ji...@apache.org> on 2022/11/01 12:24:00 UTC

[jira] [Comment Edited] (CASSANDRA-15215) VIntCoding should read and write more efficiently

    [ https://issues.apache.org/jira/browse/CASSANDRA-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627137#comment-17627137 ] 

Alex Sorokoumov edited comment on CASSANDRA-15215 at 11/1/22 12:23 PM:
-----------------------------------------------------------------------

Patch - [https://github.com/apache/cassandra/compare/trunk...Gerrrr:cassandra:15215-fixup-trunk?expand=1]

CI (still running) - [https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2052]


was (Author: gerrrr):
Patch - [https://github.com/apache/cassandra/compare/trunk...Gerrrr:cassandra:15215-fixup-trunk?expand=1]

CI (still running) - [https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2052]

 

 

 

> VIntCoding should read and write more efficiently
> -------------------------------------------------
>
>                 Key: CASSANDRA-15215
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15215
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Compaction, Local/SSTable
>            Reporter: Benedict Elliott Smith
>            Assignee: Alex Sorokoumov
>            Priority: Normal
>             Fix For: 4.1-alpha1, 4.1
>
>         Attachments: testWriteRandomLongDOP_final.png, writeUnsignedVInt_megamorphic_BB.png, writeUnsignedVInt_megamorphic_DOP.png
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Most vints occupy significantly fewer than 8 bytes, and most buffers have >= 8 bytes spare, in which case we can construct the relevant bytes in a register and memcpy them to the correct position.  Since we read and write a lot of vints, this waste is probably measurable, particularly during compaction and flush, and can probably be considered a performance bug.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org