You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by si...@apache.org on 2019/04/30 02:28:41 UTC
[bookkeeper] branch master updated: ISSUE #2073: ReadOnlyBookieTest#testBookieContinueWritingIfMulti…
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 7c62e12 ISSUE #2073: ReadOnlyBookieTest#testBookieContinueWritingIfMulti…
7c62e12 is described below
commit 7c62e1232cf8063d3b0f0dc59978da69710602b5
Author: karanmehta93 <ka...@gmail.com>
AuthorDate: Mon Apr 29 19:28:35 2019 -0700
ISSUE #2073: ReadOnlyBookieTest#testBookieContinueWritingIfMulti…
…pleLedgersPresent is flaky
Descriptions of the changes in this PR:
Updated the test to use random port number for bookie startup instead of predefined one.
### Motivation
ReadOnlyBookieTest#testBookieContinueWritingIfMultipleLedgersPresent test is flaky due to this reason.
### Changes
(Describe: what changes you have made)
Master Issue: #2073
Reviewers: Enrico Olivelli <eo...@gmail.com>, Sijie Guo <si...@apache.org>
This closes #2074 from karanmehta93/master, closes #2073
---
.../src/test/java/org/apache/bookkeeper/test/ReadOnlyBookieTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ReadOnlyBookieTest.java b/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ReadOnlyBookieTest.java
index 35b2fd3..329779c 100644
--- a/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ReadOnlyBookieTest.java
+++ b/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ReadOnlyBookieTest.java
@@ -245,7 +245,7 @@ public class ReadOnlyBookieTest extends BookKeeperClusterTestCase {
}
ServerConfiguration newConf = newServerConfiguration(
- conf.getBookiePort() + 1,
+ PortManager.nextFreePort(),
ledgerDirs[0], ledgerDirs);
bsConfs.add(newConf);
bs.add(startBookie(newConf));