You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/12/04 02:11:23 UTC

Review Request 40945: Made HDFS::copyToLocal asynchronous.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40945/
-----------------------------------------------------------

Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone.


Bugs: MESOS-3951
    https://issues.apache.org/jira/browse/MESOS-3951


Repository: mesos


Description
-------

Made HDFS::copyToLocal asynchronous.


Diffs
-----

  src/hdfs/hdfs.hpp 6bdeedf8934a681b32fca8edc251488f4213dd07 
  src/hdfs/hdfs.cpp c32c2ae9d2ace5deb09f56dcec2bd366c2d07f6b 
  src/launcher/fetcher.cpp eafdda38adde871aa33224187cd9fb774faac8fb 

Diff: https://reviews.apache.org/r/40945/diff/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request 40945: Made HDFS::copyToLocal asynchronous.

Posted by Bernd Mathiske <be...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40945/#review108958
-----------------------------------------------------------



src/hdfs/hdfs.cpp (line 302)
<https://reviews.apache.org/r/40945/#comment168406>

    By closure-capturing values from above we could print out more specifics about what subprocess could not be reaped here.


- Bernd Mathiske


On Dec. 3, 2015, 5:11 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40945/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2015, 5:11 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3951
>     https://issues.apache.org/jira/browse/MESOS-3951
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made HDFS::copyToLocal asynchronous.
> 
> 
> Diffs
> -----
> 
>   src/hdfs/hdfs.hpp 6bdeedf8934a681b32fca8edc251488f4213dd07 
>   src/hdfs/hdfs.cpp c32c2ae9d2ace5deb09f56dcec2bd366c2d07f6b 
>   src/launcher/fetcher.cpp eafdda38adde871aa33224187cd9fb774faac8fb 
> 
> Diff: https://reviews.apache.org/r/40945/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>