You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/03 21:09:09 UTC

[GitHub] [arrow-rs] carols10cents opened a new issue #999: Improve the specification of some features of dependencies

carols10cents opened a new issue #999:
URL: https://github.com/apache/arrow-rs/issues/999


   **Describe the bug**
   
   I think some chrono features can be removed and I think enabling a feature of indexmap might save a bit of build time.
   
   **Additional context**
   
   For chrono:
   
   Chrono's default features contain "oldtime", which is deprecated.
   According to [the docs](https://docs.rs/chrono/0.4.19/chrono/#duration),
   
   > new code should disable the oldtime feature and use the
   > chrono::Duration type instead. The oldtime feature is enabled by
   > default for backwards compatibility, but future versions of Chrono
   > are likely to remove the feature entirely.
   
   so follow that recommendation by setting default-features to false. And
   actually, only Arrow needs the "clock" feature, so all the other
   features can stay off too to minimize the feature set that projects
   depending on arrow or parquet are forced to enable.
   
   For indexmap:
   
   The indexmap crate uses the autocfg crate to do target detection to
   determine whether `std` is available. Arrow isn't targeting `no_std`
   environments, so the target detection isn't necessary. This might save
   some build time.
   
   https://github.com/bluss/indexmap/pull/145
   
   PR incoming!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb closed issue #999: Improve the specification of some features of dependencies

Posted by GitBox <gi...@apache.org>.

alamb closed issue #999:
URL: https://github.com/apache/arrow-rs/issues/999


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org