You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/11/22 00:21:42 UTC
Review Request 64014: Added reservations in `ResourceProviderInfo`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64014/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Joseph Wu.
Repository: mesos
Description
-------
The `reservations` field is used to set up the default reservation stack
for resources reported by the resource provider.
Diffs
-----
include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435
include/mesos/resources.hpp 08c544d05b6199ac77f8a71720c13eb0f2decf60
include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e
src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc
Diff: https://reviews.apache.org/r/64014/diff/1/
Testing
-------
make
Thanks,
Chun-Hung Hsiao
Re: Review Request 64014: Added default reservations in
`ResourceProviderInfo`.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64014/#review191781
-----------------------------------------------------------
include/mesos/mesos.proto
Line 1035 (original)
<https://reviews.apache.org/r/64014/#comment269697>
Why this move? You should put this close to CSIPluginInfo and CSIPluginContianerInfo.
include/mesos/resources.hpp
Lines 65 (patched)
<https://reviews.apache.org/r/64014/#comment269695>
2 lines apart
include/mesos/v1/mesos.proto
Line 1027 (original)
<https://reviews.apache.org/r/64014/#comment269698>
Ditto.
src/common/type_utils.cpp
Lines 408 (patched)
<https://reviews.apache.org/r/64014/#comment269696>
Update src/v1/mesos.cpp
- Jie Yu
On Nov. 23, 2017, 1:38 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64014/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2017, 1:38 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `default_reservations` field is used to set up the default
> reservation stack for new resources from the resource provider.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435
> include/mesos/resources.hpp 08c544d05b6199ac77f8a71720c13eb0f2decf60
> include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e
> src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc
>
>
> Diff: https://reviews.apache.org/r/64014/diff/3/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64014: Added default reservations in
`ResourceProviderInfo`.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64014/#review191819
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Nov. 23, 2017, 10:13 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64014/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2017, 10:13 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `default_reservations` field is used to set up the default
> reservation stack for new resources from the resource provider.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435
> include/mesos/resources.hpp 08c544d05b6199ac77f8a71720c13eb0f2decf60
> include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e
> include/mesos/v1/resources.hpp d59fa35d1bcdab30258fd31e483ec6b45578f470
> src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc
> src/v1/mesos.cpp 44767b1f87ff5d858df890ef75c77736ba969f94
>
>
> Diff: https://reviews.apache.org/r/64014/diff/4/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64014: Added default reservations in
`ResourceProviderInfo`.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64014/
-----------------------------------------------------------
(Updated Nov. 23, 2017, 10:13 a.m.)
Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Joseph Wu.
Changes
-------
Addressed jieyu's comments.
Repository: mesos
Description
-------
The `default_reservations` field is used to set up the default
reservation stack for new resources from the resource provider.
Diffs (updated)
-----
include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435
include/mesos/resources.hpp 08c544d05b6199ac77f8a71720c13eb0f2decf60
include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e
include/mesos/v1/resources.hpp d59fa35d1bcdab30258fd31e483ec6b45578f470
src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc
src/v1/mesos.cpp 44767b1f87ff5d858df890ef75c77736ba969f94
Diff: https://reviews.apache.org/r/64014/diff/4/
Changes: https://reviews.apache.org/r/64014/diff/3-4/
Testing
-------
make
Thanks,
Chun-Hung Hsiao
Re: Review Request 64014: Added default reservations in
`ResourceProviderInfo`.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64014/
-----------------------------------------------------------
(Updated Nov. 23, 2017, 1:38 a.m.)
Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Joseph Wu.
Changes
-------
Added missing changes.
Repository: mesos
Description (updated)
-------
The `default_reservations` field is used to set up the default
reservation stack for new resources from the resource provider.
Diffs (updated)
-----
include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435
include/mesos/resources.hpp 08c544d05b6199ac77f8a71720c13eb0f2decf60
include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e
src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc
Diff: https://reviews.apache.org/r/64014/diff/3/
Changes: https://reviews.apache.org/r/64014/diff/2-3/
Testing
-------
make
Thanks,
Chun-Hung Hsiao
Re: Review Request 64014: Added default reservations in
`ResourceProviderInfo`.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64014/
-----------------------------------------------------------
(Updated Nov. 23, 2017, 12:47 a.m.)
Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Joseph Wu.
Changes
-------
Name change.
Summary (updated)
-----------------
Added default reservations in `ResourceProviderInfo`.
Repository: mesos
Description
-------
The `reservations` field is used to set up the default reservation stack
for resources reported by the resource provider.
Diffs (updated)
-----
include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435
include/mesos/resources.hpp 08c544d05b6199ac77f8a71720c13eb0f2decf60
include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e
src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc
Diff: https://reviews.apache.org/r/64014/diff/2/
Changes: https://reviews.apache.org/r/64014/diff/1-2/
Testing
-------
make
Thanks,
Chun-Hung Hsiao