You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2026/05/12 08:25:18 UTC

[PR] CAMEL-23477: camel-jbang-mcp - Stop re-embedding pomContent in migrateProject prompt [camel]

oscerd opened a new pull request, #23140:
URL: https://github.com/apache/camel/pull/23140

## Summary

Stops re-embedding the full `pomContent` argument inside the `migrate_project` prompt
instructions. Previously, `PromptDefinitions.migrateProject` inlined the entire pom.xml
inside a multi-paragraph workflow block, so the prompt size grew linearly with pom size —
duplicating content the client typically already has in conversation context. Verbose
"Step 1 … Step 6" descriptions are also compressed into a tight numbered list.

JIRA: [CAMEL-23477](https://issues.apache.org/jira/browse/CAMEL-23477)

## Changes

- `pomContent` is now `required = false` (backward compatible — old clients still send it).
- The prompt no longer interpolates the full pom content; instead it emits a one-line
acknowledgement of whether a pom was supplied or should be read from conversation context.
- Workflow descriptions compressed from ~6 paragraphs of "Step N: …" into a 6-item numbered
list, preserving every tool call and decision branch (`camel_migration_analyze`,
`camel_version_list`, `camel_migration_wildfly_karaf`, `camel_migration_compatibility`,
`camel_migration_recipes`, `camel_migration_guide_search`).

## Test plan

- [x] Updated `PromptDefinitionsTest`:
- Replaced `migrateProjectContainsPomContent` (which asserted the pom was inlined).
- Added `migrateProjectDoesNotInlinePomContent` — supplies a 1000×`<dependency/>` pom and
asserts the resulting prompt size matches the size produced by a small pom, and that the
large pom text is not present in the output.
- Added `migrateProjectAcknowledgesSuppliedPom`, `migrateProjectFallsBackToContextWhenPomOmitted`,
and `migrateProjectBlankPomFallsBackToContext`.
- [x] `mvn verify` in `dsl/camel-jbang/camel-jbang-mcp` — passes.
- [x] Full reactor build (`mvn clean install -DskipTests`) — passes; no regen artifacts.

## Acceptance

> Prompt size does not scale with `pomContent` length.

Verified by `migrateProjectDoesNotInlinePomContent`.

---
_Claude Code on behalf of Andrea Cosentino_

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-23477: camel-jbang-mcp - Stop re-embedding pomContent in migrateProject prompt [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #23140:
URL: https://github.com/apache/camel/pull/23140#issuecomment-4428794354

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `dsl/camel-jbang/camel-jbang-mcp`
   
   :warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
   
   - `dsl/camel-jbang/camel-jbang-mcp`: 1 test(s) disabled on GitHub Actions
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/25722676254)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-23477: camel-jbang-mcp - Stop re-embedding pomContent in migrateProject prompt [camel]

Posted by "oscerd (via GitHub)" <gi...@apache.org>.

oscerd merged PR #23140:
URL: https://github.com/apache/camel/pull/23140


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-23477: camel-jbang-mcp - Stop re-embedding pomContent in migrateProject prompt [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #23140:
URL: https://github.com/apache/camel/pull/23140#issuecomment-4428673216

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org