You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/05/02 13:31:24 UTC
[GitHub] [maven-compiler-plugin] pzygielo opened a new pull request #50: Remove unused private field
pzygielo opened a new pull request #50:
URL: https://github.com/apache/maven-compiler-plugin/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #50: Remove unused private field
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #50:
URL: https://github.com/apache/maven-compiler-plugin/pull/50#issuecomment-841055578
What can I do to move it forward even more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #50: Remove unused private field
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #50:
URL: https://github.com/apache/maven-compiler-plugin/pull/50#issuecomment-834193615
What can I do to move it forward?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] michael-o commented on pull request #50: Remove unused private field
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #50:
URL: https://github.com/apache/maven-compiler-plugin/pull/50#issuecomment-830834846
>
>
> > This may be a bug, no?
>
> I'm not sure what you mean by that.
Obviously, not the empty list should be passed. This case could either be what you say or simply a bug that `compilePath` is not passed down to the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] rfscholte commented on pull request #50: Remove unused private field
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #50:
URL: https://github.com/apache/maven-compiler-plugin/pull/50#issuecomment-841628802
Merged with https://github.com/apache/maven-compiler-plugin/commit/419bf040893dac8f300deb5b36daf5f487dea8d2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] michael-o commented on pull request #50: Remove unused private field
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #50:
URL: https://github.com/apache/maven-compiler-plugin/pull/50#issuecomment-830812010
This may be a bug, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #50: Remove unused private field
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #50:
URL: https://github.com/apache/maven-compiler-plugin/pull/50#issuecomment-830835451
`compilePath` is unused field in `TestCompilerMojo`. That field is removed and then change in test that sets non-existent field follows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #50: Remove unused private field
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #50:
URL: https://github.com/apache/maven-compiler-plugin/pull/50#issuecomment-830821778
> This may be a bug, no?
I'm not sure what you mean by that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] rfscholte closed pull request #50: Remove unused private field
Posted by GitBox <gi...@apache.org>.
rfscholte closed pull request #50:
URL: https://github.com/apache/maven-compiler-plugin/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org