You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "mappjzc (via GitHub)" <gi...@apache.org> on 2023/05/30 16:56:15 UTC
[GitHub] [incubator-devlake] mappjzc opened a new pull request, #5323: Zentao update the data transformation logic
mappjzc opened a new pull request, #5323:
URL: https://github.com/apache/incubator-devlake/pull/5323
### Summary
Update the data transformation logic
including
table.issues
table.sprints
table.boards
Add changelog convert
Fix and add some e2e for changes.
### Does this close any open issues?
Closes #5188
### Screenshots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh merged pull request #5323: Zentao update the data transformation logic
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh merged PR #5323:
URL: https://github.com/apache/incubator-devlake/pull/5323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on a diff in pull request #5323: Zentao update the data transformation logic
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on code in PR #5323:
URL: https://github.com/apache/incubator-devlake/pull/5323#discussion_r1212522451
##########
backend/plugins/zentao/models/migrationscripts/20221121_add_init_tables.go:
##########
@@ -57,11 +58,12 @@ func (*addInitTables) Up(basicRes context.BasicRes) errors.Error {
&archived.ZentaoTask{},
&archived.ZentaoAccount{},
&archived.ZentaoDepartment{},
+ &archived.ZentaoScopeConfig{},
)
}
func (*addInitTables) Version() uint64 {
- return 20230505000001
+ return 20230530000001
Review Comment:
We should create a new migration script for adding new tables.
adding a new tables to an existing script is not a good practice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org