[GitHub] [airflow] KevinYang21 commented on pull request #18675: New Tree View

[GitBox <gi...@apache.org>]

KevinYang21 commented on pull request #18675:
URL: https://github.com/apache/airflow/pull/18675#issuecomment-1038732956


   Thank you @bbovenzi for the work. I'm all for a more powerful UI and appreciate every bit of excellent effort you guys made/are making.
   
   We already have some great discussion here in this thread and I figure I'll share a bit of my thoughts.
   
   > I do not like this solution because it only shows relations wilth lines which might go up and down arbitrary number of rows (including long lines that will stretch far beyond the screen in big graphs). The big benefit of the solution proposed by @bbovenzi is that you see the direct upstream/downstream task names immediately next to the task in the graph, even if in the grid they will be many, many rows away.
   > 
   > Tracking such relations will be next to impossible if we add lines to the grid.
   
   In the current tree view, we will have a similar problem of having long lines that go beyond the screen, as shown in figure 1. Even in a partial graph view showing three layers of lineage, if the task has a couple hundred of parents/children, we will have similar problem.
   
   IMO viewing full lineage in a huge graph/tree is less useful--people look at the lineage/dependency more when dealing with smaller DAG/subdag/rooted DAG. In those cases, being able to tell the progress and dependencies in one view w/o clutter is very useful and important--that's what brought us the tree view and why it's popular (at least in Airbnb, tree view is visited 13x times than graph view).
   
   Do not get me wrong, I love this table view and definately can envision people using it often, including myself. But with the current implementation (+ optional partial graph view), I'm not convinced that it should be a replacement of the existing tree view, but rather a nice additional table view in our collections to better serve some use cases, e.g. task group heavy DAGs.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org